Dev/e3d cpp#227
Draft
marcinn wants to merge 6 commits into
Draft
Conversation
Incldues: * game objects browser in the editor (nodebank browser) * SceneryResourceLoader removal and threaded scene loading (picked from main-unstable) * cleaning the code of Cabin3D * compatibility fixes in RailVehicle3D (related to E3DModelInstance changes) * MaszynaEditorPluginDelegate interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review notes
Hot-reload Crashes
Potential source:
E3DModelInstanceholds raw pointer to the current instancer; pointer may not be nullptr and still referencing to already deleted instancerNodebankGridItemholds reference to E3DModelInstances