Skip to content

Add multimonitor configuration#237

Open
JezSonic wants to merge 1 commit into
mainfrom
dev/multi-mon-support
Open

Add multimonitor configuration#237
JezSonic wants to merge 1 commit into
mainfrom
dev/multi-mon-support

Conversation

@JezSonic
Copy link
Copy Markdown
Member

@JezSonic JezSonic commented May 9, 2026

Adds configurable multimonitor support

Copy link
Copy Markdown
Member

@marcinn marcinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check camera logic nor checked how it works, but for now I am adding some notes and suggestions.

Comment thread addons/libmaszyna/player/free_camera.gd Outdated
Comment thread addons/libmaszyna/player/player.gd
Comment thread addons/libmaszyna/player/multi_monitor_manager.gd
Comment thread addons/libmaszyna/player/multi_monitor_manager.gd
Comment thread addons/libmaszyna/player/multi_monitor_manager.gd
@JezSonic
Copy link
Copy Markdown
Member Author

JezSonic commented May 9, 2026

draft, not ready for review yet

@marcinn
Copy link
Copy Markdown
Member

marcinn commented May 9, 2026

It looks pretty insane! Wow!
Few questions:

  • why 3 windows only?
  • could you add Render Cabin (bool) option in user settings and conditionally disable e3d cabin rendering?

Issues:

  • rotation 0 is way off than rotation -1 and 1

@marcinn
Copy link
Copy Markdown
Member

marcinn commented May 9, 2026

draft, not ready for review yet

for me it is very close to accept this feature

@JezSonic
Copy link
Copy Markdown
Member Author

JezSonic commented May 9, 2026

not yet, FOV is bad, and it needs a lot of polish. And you can set the number of monitors up to 3.

@JezSonic
Copy link
Copy Markdown
Member Author

JezSonic commented May 9, 2026

rotation 0 is way off than rotation -1 and 1

Rotation 0 is "automatic"

@JezSonic JezSonic force-pushed the dev/multi-mon-support branch 2 times, most recently from 636f4d8 to cdc3a71 Compare May 13, 2026 17:42
@JezSonic JezSonic force-pushed the dev/multi-mon-support branch from cdc3a71 to ee075f1 Compare May 13, 2026 17:43
@JezSonic JezSonic marked this pull request as ready for review May 13, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants