Skip to content

chore: 移除已废弃的 InteractiveModel 及相关资源依赖#24

Merged
Aliothmoon merged 2 commits into
mainfrom
refactor/rm-model
Mar 5, 2026
Merged

chore: 移除已废弃的 InteractiveModel 及相关资源依赖#24
Aliothmoon merged 2 commits into
mainfrom
refactor/rm-model

Conversation

@Aliothmoon
Copy link
Copy Markdown
Member

@Aliothmoon Aliothmoon commented Mar 5, 2026

Summary by Sourcery

移除已弃用的 InteractiveModel 组件及其相关的 3D 后期处理依赖。

改进:

  • package.json 中清理未使用的 3D 渲染和后期处理依赖。

维护:

  • 删除已弃用的 InteractiveModel 组件以及在 lockfile 中对应的条目。
Original summary in English

Summary by Sourcery

Remove the deprecated InteractiveModel component and its associated 3D post-processing dependencies.

Enhancements:

  • Clean up unused 3D rendering and post-processing dependencies from package.json.

Chores:

  • Delete the deprecated InteractiveModel component and corresponding entries from the lockfile.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我发现了 1 个问题,并留下了一些整体性的反馈:

  • 由于 InteractiveModel.tsx 以及与其相关的 3D 依赖已经被移除,请再次检查并清理所有剩余的引用和未使用的资源(例如模型文件、纹理,或仅用于承载该视图的路由/组件),以避免在仓库中留下无用资源。
给 AI 代理的提示
Please address the comments from this code review:

## Overall Comments
- Since `InteractiveModel.tsx` and its 3D-related dependencies are removed, double-check and clean up any remaining references and unused assets (e.g., model files, textures, or routes/components that only existed to host this view) to avoid leaving dead resources in the repo.

## Individual Comments

### Comment 1
<location path="package.json" line_range="18-21" />
<code_context>
   "dependencies": {
     "@react-three/drei": "^10.7.7",
     "@react-three/fiber": "^9.4.0",
-    "@react-three/postprocessing": "^3.0.4",
     "baseline-browser-mapping": "^2.9.19",
     "clsx": "^2.1.1",
</code_context>
<issue_to_address>
**suggestion (performance):** Consider whether other react-three dependencies can also be removed to reduce bundle size if the 3D feature was fully dropped.

Since `InteractiveModel.tsx` and the postprocessing deps are gone, please verify whether `@react-three/fiber` and `@react-three/drei` are still used anywhere. If not, removing them would further reduce bundle size and install time.

Suggested implementation:

```
  "dependencies": {
    "baseline-browser-mapping": "^2.9.19",
    "clsx": "^2.1.1",

```

1. Run a global search in the repo for `@react-three/fiber` and `@react-three/drei` to confirm they are not imported anywhere. If they are still imported, those usages must also be removed or refactored before this change.
2. If these packages appear under `devDependencies` or in any workspace packages, remove them there as well to fully drop them from the project.
3. After updating `package.json`, run your package manager (e.g., `pnpm install`, `npm install`, or `yarn install`) and verify the app builds and runs without errors.
</issue_to_address>

Sourcery 对开源项目免费 —— 如果你觉得我们的代码评审有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English

Hey - I've found 1 issue, and left some high level feedback:

  • Since InteractiveModel.tsx and its 3D-related dependencies are removed, double-check and clean up any remaining references and unused assets (e.g., model files, textures, or routes/components that only existed to host this view) to avoid leaving dead resources in the repo.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `InteractiveModel.tsx` and its 3D-related dependencies are removed, double-check and clean up any remaining references and unused assets (e.g., model files, textures, or routes/components that only existed to host this view) to avoid leaving dead resources in the repo.

## Individual Comments

### Comment 1
<location path="package.json" line_range="18-21" />
<code_context>
   "dependencies": {
     "@react-three/drei": "^10.7.7",
     "@react-three/fiber": "^9.4.0",
-    "@react-three/postprocessing": "^3.0.4",
     "baseline-browser-mapping": "^2.9.19",
     "clsx": "^2.1.1",
</code_context>
<issue_to_address>
**suggestion (performance):** Consider whether other react-three dependencies can also be removed to reduce bundle size if the 3D feature was fully dropped.

Since `InteractiveModel.tsx` and the postprocessing deps are gone, please verify whether `@react-three/fiber` and `@react-three/drei` are still used anywhere. If not, removing them would further reduce bundle size and install time.

Suggested implementation:

```
  "dependencies": {
    "baseline-browser-mapping": "^2.9.19",
    "clsx": "^2.1.1",

```

1. Run a global search in the repo for `@react-three/fiber` and `@react-three/drei` to confirm they are not imported anywhere. If they are still imported, those usages must also be removed or refactored before this change.
2. If these packages appear under `devDependencies` or in any workspace packages, remove them there as well to fully drop them from the project.
3. After updating `package.json`, run your package manager (e.g., `pnpm install`, `npm install`, or `yarn install`) and verify the app builds and runs without errors.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread package.json
Comment on lines -18 to 21
"@react-three/postprocessing": "^3.0.4",
"baseline-browser-mapping": "^2.9.19",
"clsx": "^2.1.1",
"framer-motion": "^12.23.24",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): 可以考虑是否也移除其他 react-three 依赖,以在 3D 功能已经完全下线的情况下进一步减小 bundle 体积。

由于 InteractiveModel.tsx 和后处理相关依赖已经被删除,请确认项目中是否仍然在任何地方使用 @react-three/fiber@react-three/drei。如果没有使用,移除它们可以进一步减少 bundle 体积和安装时间。

建议的修改示例:

  "dependencies": {
    "baseline-browser-mapping": "^2.9.19",
    "clsx": "^2.1.1",

  1. 在整个仓库中全局搜索 @react-three/fiber@react-three/drei,确认它们没有在任何地方被导入。如果仍有导入,这些用法需要在本次变更前一并移除或重构。
  2. 如果这些包出现在 devDependencies 中或任何 workspace 包中,也请一并删除,以便彻底从项目中移除它们。
  3. 更新 package.json 后,运行你的包管理器(例如 pnpm installnpm installyarn install),并确认应用可以正常构建和运行且没有报错。
Original comment in English

suggestion (performance): Consider whether other react-three dependencies can also be removed to reduce bundle size if the 3D feature was fully dropped.

Since InteractiveModel.tsx and the postprocessing deps are gone, please verify whether @react-three/fiber and @react-three/drei are still used anywhere. If not, removing them would further reduce bundle size and install time.

Suggested implementation:

  "dependencies": {
    "baseline-browser-mapping": "^2.9.19",
    "clsx": "^2.1.1",

  1. Run a global search in the repo for @react-three/fiber and @react-three/drei to confirm they are not imported anywhere. If they are still imported, those usages must also be removed or refactored before this change.
  2. If these packages appear under devDependencies or in any workspace packages, remove them there as well to fully drop them from the project.
  3. After updating package.json, run your package manager (e.g., pnpm install, npm install, or yarn install) and verify the app builds and runs without errors.

@Aliothmoon Aliothmoon merged commit 33c765a into main Mar 5, 2026
3 checks passed
@Aliothmoon Aliothmoon deleted the refactor/rm-model branch March 5, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant