Skip to content

chore: 移除已废弃的 InteractiveModel 及相关资源依赖 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aliothmoon merged 2 commits into from
Mar 5, 2026
Merged

chore: 移除已废弃的 InteractiveModel 及相关资源依赖 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abbc334
chore: 移除已废弃的 InteractiveModel 及相关资源依赖
Aliothmoon Mar 5, 2026
7556f1f
chore: bump next.js version
Aliothmoon Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
305 changes: 0 additions & 305 deletions app/components/InteractiveModel.tsx
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,13 @@
"dependencies": {
"@react-three/drei": "^10.7.7",
"@react-three/fiber": "^9.4.0",
"@react-three/postprocessing": "^3.0.4",
"baseline-browser-mapping": "^2.9.19",
"clsx": "^2.1.1",
"framer-motion": "^12.23.24",
Comment on lines -18 to 21
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): 可以考虑是否也移除其他 react-three 依赖，以在 3D 功能已经完全下线的情况下进一步减小 bundle 体积。

由于 InteractiveModel.tsx 和后处理相关依赖已经被删除，请确认项目中是否仍然在任何地方使用 @react-three/fiber 和 @react-three/drei。如果没有使用，移除它们可以进一步减少 bundle 体积和安装时间。

建议的修改示例：

  "dependencies": {
    "baseline-browser-mapping": "^2.9.19",
    "clsx": "^2.1.1",
  1. 在整个仓库中全局搜索 @react-three/fiber 和 @react-three/drei，确认它们没有在任何地方被导入。如果仍有导入，这些用法需要在本次变更前一并移除或重构。
  2. 如果这些包出现在 devDependencies 中或任何 workspace 包中，也请一并删除，以便彻底从项目中移除它们。
  3. 更新 package.json 后，运行你的包管理器（例如 pnpm install、npm install 或 yarn install），并确认应用可以正常构建和运行且没有报错。
Original comment in English

suggestion (performance): Consider whether other react-three dependencies can also be removed to reduce bundle size if the 3D feature was fully dropped.

Since InteractiveModel.tsx and the postprocessing deps are gone, please verify whether @react-three/fiber and @react-three/drei are still used anywhere. If not, removing them would further reduce bundle size and install time.

Suggested implementation:

  "dependencies": {
    "baseline-browser-mapping": "^2.9.19",
    "clsx": "^2.1.1",
  1. Run a global search in the repo for @react-three/fiber and @react-three/drei to confirm they are not imported anywhere. If they are still imported, those usages must also be removed or refactored before this change.
  2. If these packages appear under devDependencies or in any workspace packages, remove them there as well to fully drop them from the project.
  3. After updating package.json, run your package manager (e.g., pnpm install, npm install, or yarn install) and verify the app builds and runs without errors.

"i18next": "^25.7.1",
"lucide-react": "^0.555.0",
"next": "16.0.7",
"next": "16.1.5",
"next-themes": "^0.4.6",
"postprocessing": "^6.38.2",
"react": "19.2.0",
"react-dom": "19.2.0",
"react-i18next": "^16.4.0",
Expand Down
Loading
Loading