feat: deprecated Recording

MaaXYZ/MaaFramework@8e8292b

Author: moomiji

src/MaaFramework.Binding.Native/MaaController.cs

@@ -68,8 +68,10 @@ public bool SetOption<T>(ControllerOption opt, T value)
         {
             (int vvvv, ControllerOption.ScreenshotTargetLongSide
                     or ControllerOption.ScreenshotTargetShortSide) => vvvv.ToMaaOptionValue(),
+#pragma warning disable CS0618 // 类型或成员已过时
             (bool vvv, ControllerOption.Recording
                     or ControllerOption.ScreenshotUseRawSize) => vvv.ToMaaOptionValue(),
+#pragma warning restore CS0618 // 类型或成员已过时
 
             _ => throw new NotSupportedException($"'{nameof(ControllerOption)}.{opt}' or type '{typeof(T)}' is not supported."),
         };

src/MaaFramework.Binding.Native/MaaUtility.cs

@@ -31,10 +31,12 @@ public bool SetOption<T>(GlobalOption opt, T value)
         {
             (int vvvv, GlobalOption.StdoutLevel) => vvvv.ToMaaOptionValue(),
             (string v, GlobalOption.LogDir) => v.ToMaaOptionValue(),
+#pragma warning disable CS0618 // 类型或成员已过时
             (bool vvv, GlobalOption.SaveDraw
                     or GlobalOption.Recording
                     or GlobalOption.ShowHitDraw
                     or GlobalOption.DebugMode) => vvv.ToMaaOptionValue(),
+#pragma warning restore CS0618 // 类型或成员已过时
 
             (LoggingLevel v, GlobalOption.StdoutLevel) => ((int)v).ToMaaOptionValue(),
 

src/MaaFramework.Binding.UnitTests/Test_IMaaController.cs

@@ -141,7 +141,6 @@ public void CreateInstances()
     [MaaData(MaaTypes.All, nameof(Data), ControllerOption.ScreenshotTargetLongSide, 1280)]
     [MaaData(MaaTypes.All, nameof(Data), ControllerOption.ScreenshotTargetShortSide, 720)]
     [MaaData(MaaTypes.All, nameof(Data), ControllerOption.ScreenshotUseRawSize, false)]
-    [MaaData(MaaTypes.All, nameof(Data), ControllerOption.Recording, false)]
     public void Interface_SetOption(MaaTypes type, IMaaController maaController, ControllerOption opt, object arg)
     {
         Assert.IsNotNull(maaController);
@@ -368,7 +367,6 @@ public void Interface_Uuid(MaaTypes type, IMaaController maaController)
     [MaaData(MaaTypes.All, nameof(Data), ControllerOption.ScreenshotTargetLongSide, 0.0)]
     [MaaData(MaaTypes.All, nameof(Data), ControllerOption.ScreenshotTargetShortSide, 0.0)]
     [MaaData(MaaTypes.All, nameof(Data), ControllerOption.ScreenshotUseRawSize, 0.0)]
-    [MaaData(MaaTypes.All, nameof(Data), ControllerOption.Recording, 0.0)]
     public void Interface_SetOption_InvalidData(MaaTypes type, IMaaController maaController, ControllerOption opt, object arg)
     {
         Assert.IsNotNull(maaController);

src/MaaFramework.Binding.UnitTests/Test_IMaaUtility.cs

@@ -40,10 +40,8 @@ public void Interface_Version(MaaTypes type, IMaaUtility maaUtility)
     [TestMethod]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.LogDir, nameof(Common.DebugPath))]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.SaveDraw, false)]
-    [MaaData(MaaTypes.All, nameof(Data), GlobalOption.Recording, false)]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.StdoutLevel, LoggingLevel.Off)]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.StdoutLevel, 0)]
-    [MaaData(MaaTypes.All, nameof(Data), GlobalOption.ShowHitDraw, false)]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.DebugMode, false)]
     public void Interface_SetOption(MaaTypes type, IMaaUtility maaUtility, GlobalOption opt, object arg)
     {
@@ -59,9 +57,7 @@ public void Interface_SetOption(MaaTypes type, IMaaUtility maaUtility, GlobalOpt
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.Invalid, "Anything")]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.LogDir, 0.0)]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.SaveDraw, 0.0)]
-    [MaaData(MaaTypes.All, nameof(Data), GlobalOption.Recording, 0.0)]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.StdoutLevel, 0.0)]
-    [MaaData(MaaTypes.All, nameof(Data), GlobalOption.ShowHitDraw, 0.0)]
     [MaaData(MaaTypes.All, nameof(Data), GlobalOption.DebugMode, 0.0)]
     public void Interface_SetOption_InvalidData(MaaTypes type, IMaaUtility maaUtility, GlobalOption opt, object arg)
     {

src/MaaFramework.Binding/Extensions/MaaOptionExtensions.cs

@@ -22,6 +22,7 @@ public static bool SetOption_ScreenshotUseRawSize(this IMaaOption<ControllerOpti
         => opt?.SetOption(ControllerOption.ScreenshotUseRawSize, value) ?? throw new ArgumentNullException(nameof(opt));
 
     /// <inheritdoc cref="IMaaOption{T}.SetOption{T}"/>
+    [Obsolete("Deprecated from v4.5.0.")]
     public static bool SetOption_Recording(this IMaaOption<ControllerOption>? opt, bool value)
         => opt?.SetOption(ControllerOption.Recording, value) ?? throw new ArgumentNullException(nameof(opt));
 
@@ -34,6 +35,7 @@ public static bool SetOption_SaveDraw(this IMaaOption<GlobalOption>? opt, bool v
         => opt?.SetOption(GlobalOption.SaveDraw, value) ?? throw new ArgumentNullException(nameof(opt));
 
     /// <inheritdoc cref="IMaaOption{T}.SetOption{T}"/>
+    [Obsolete("Deprecated from v4.5.0.")]
     public static bool SetOption_Recording(this IMaaOption<GlobalOption>? opt, bool value)
         => opt?.SetOption(GlobalOption.Recording, value) ?? throw new ArgumentNullException(nameof(opt));
 
@@ -42,6 +44,7 @@ public static bool SetOption_StdoutLevel(this IMaaOption<GlobalOption>? opt, Log
         => opt?.SetOption(GlobalOption.StdoutLevel, value) ?? throw new ArgumentNullException(nameof(opt));
 
     /// <inheritdoc cref="IMaaOption{T}.SetOption{T}"/>
+    [Obsolete("Deprecated from v4.5.0.")]
     public static bool SetOption_ShowHitDraw(this IMaaOption<GlobalOption>? opt, bool value)
         => opt?.SetOption(GlobalOption.ShowHitDraw, value) ?? throw new ArgumentNullException(nameof(opt));