chore: fix code quality analysis warnings

moomiji · moomiji · commit fba93011f69c · 2025-11-30T00:36:17.000+08:00
diff --git a/src/MaaFramework.Binding.Native/Buffers/MaaStringListBuffer.cs b/src/MaaFramework.Binding.Native/Buffers/MaaStringListBuffer.cs
@@ -153,7 +153,7 @@ public override bool TryIndexOf(MaaStringBuffer item, out MaaSize index)
             for (MaaSize tmpIndex = 0; tmpIndex < count; tmpIndex++)
             {
                 if (MaaStringBuffer.TryGetValue(MaaStringListBufferAt(Handle, tmpIndex), out var stringInList)
-                    && stringInList.Equals(stringInItem))
+                    && stringInList.Equals(stringInItem, StringComparison.Ordinal))
                 {
                     index = tmpIndex;
                     return true;
diff --git a/src/MaaFramework.Binding.Native/MaaAgentClient.cs b/src/MaaFramework.Binding.Native/MaaAgentClient.cs
@@ -61,6 +61,8 @@ public static MaaAgentClient Create(MaaResource resource)
     /// <returns>The <see cref="MaaAgentClient"/> instance.</returns>
     public static MaaAgentClient Create(string identifier, MaaTasker maa)
     {
+        ArgumentNullException.ThrowIfNull(maa);
+
         var client = new MaaAgentClient(identifier) { Resource = maa.Resource, };
         _ = MaaAgentClientRegisterTaskerSink(client.Handle, maa.Handle);
         _ = MaaAgentClientRegisterResourceSink(client.Handle, maa.Resource.Handle);
@@ -179,6 +181,8 @@ public bool LinkStart(ProcessStartInfo info, CancellationToken cancellationToken
     /// </remarks>
     public bool LinkStart(IMaaAgentClient.AgentServerStartupMethod method, CancellationToken cancellationToken = default)
     {
+        ArgumentNullException.ThrowIfNull(method);
+
         if (_agentServerProcess is null or { HasExited: true })
         {
             ArgumentException.ThrowIfNullOrEmpty(Id);
@@ -213,7 +217,7 @@ public async Task<bool> LinkStartUnlessProcessExit(Process process, Cancellation
             cts.Token.ThrowIfCancellationRequested();
 
             return completedTask != serverExitTask
-                && linkStartTask.Result;
+                && await linkStartTask;
         }
         finally
         {
diff --git a/src/MaaFramework.Binding.Native/MaaAgentServer.cs b/src/MaaFramework.Binding.Native/MaaAgentServer.cs
@@ -172,6 +172,8 @@ public MaaAgentServer Detach()
     }
 }
 
+#pragma warning disable CA1707 // 标识符不应包含下划线
+
 /// <summary>
 ///     A static class providing extension methods for <see cref="MaaAgentServer"/>.
 /// </summary>
diff --git a/src/MaaFramework.Binding.Native/MaaController/MaaAdbController.cs b/src/MaaFramework.Binding.Native/MaaController/MaaAdbController.cs
@@ -31,6 +31,7 @@ public class MaaAdbController : MaaController
     /// <exception cref="MaaJobStatusException"/>
     public MaaAdbController(AdbDeviceInfo info, LinkOption link = LinkOption.Start, CheckStatusOption check = CheckStatusOption.ThrowIfNotSucceeded)
     {
+        ArgumentNullException.ThrowIfNull(info);
         ArgumentException.ThrowIfNullOrEmpty(info.AdbPath);
         ArgumentException.ThrowIfNullOrEmpty(info.AdbSerial);
         ArgumentException.ThrowIfNullOrEmpty(info.Config);
diff --git a/src/MaaFramework.Binding.Native/MaaController/MaaWin32Controller.cs b/src/MaaFramework.Binding.Native/MaaController/MaaWin32Controller.cs
@@ -31,6 +31,7 @@ public class MaaWin32Controller : MaaController
     /// <exception cref="MaaJobStatusException"/>
     public MaaWin32Controller(DesktopWindowInfo info, LinkOption link = LinkOption.Start, CheckStatusOption check = CheckStatusOption.ThrowIfNotSucceeded)
     {
+        ArgumentNullException.ThrowIfNull(info);
         if (info.Handle == nint.Zero) throw new ArgumentException("Value cannot be zero.", "info.Handle");
 
         var handle = MaaWin32ControllerCreate(info.Handle, (MaaWin32ScreencapMethod)info.ScreencapMethod, (MaaWin32InputMethod)info.MouseMethod, (MaaWin32InputMethod)info.KeyboardMethod);
diff --git a/src/MaaFramework.Binding.Native/MaaTasker.cs b/src/MaaFramework.Binding.Native/MaaTasker.cs
@@ -143,8 +143,10 @@ public bool SetOption<T>(TaskerOption opt, T value)
 #pragma warning restore
     }
 
+#pragma warning disable CA2213 // 应释放可释放的字段
     private MaaResource _resource = null!;
     private MaaController _controller = null!;
+#pragma warning restore CA2213 // 应释放可释放的字段
 
     IMaaResource IMaaTasker.Resource
     {
diff --git a/src/MaaFramework.Binding.UnitTests/.editorconfig b/src/MaaFramework.Binding.UnitTests/.editorconfig
diff --git a/src/MaaFramework.Binding.UnitTests/MaaFramework.Binding.UnitTests.csproj b/src/MaaFramework.Binding.UnitTests/MaaFramework.Binding.UnitTests.csproj
@@ -1,49 +1,50 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
-    <ItemGroup>
-        <PackageReference Include="Microsoft.NET.Test.Sdk" />
-        <PackageReference Include="MSTest.TestAdapter" />
-        <PackageReference Include="MSTest.TestFramework" />
-        <PackageReference Include="SixLabors.ImageSharp" />
-
-        <ProjectReference Include="..\MaaFramework\MaaFramework.csproj" Private="false" />
-        <ProjectReference Include="..\MaaFramework.Binding.Extensions\MaaFramework.Binding.Extensions.csproj" />
-
-        <None Include="..\Common\TestParam.runsettings" />
-        <None Include="SampleResource\**">
-            <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-        </None>
-    </ItemGroup>
-
-    <PropertyGroup>
-        <GenerateProgramFile>false</GenerateProgramFile>
-
-        <NoWarn>$(NoWarn);S1121,S1656,S1199,IDE0022,IDE0060,IDE0072</NoWarn>
-    </PropertyGroup>
-
-    <!-- Maa Test Constants -->
-    <PropertyGroup>
-        <DefineConstants>$(DefineConstants);MAA_NATIVE;</DefineConstants>
-    </PropertyGroup>
-
-    <Choose>
-        <When Condition="$([System.OperatingSystem]::IsOSPlatform('WINDOWS'))">
-            <PropertyGroup>
-                <DefineConstants>$(DefineConstants);MAA_WIN32;</DefineConstants>
-            </PropertyGroup>
-        </When>
-        <Otherwise>
-        </Otherwise>
-    </Choose>
-
-    <Choose>
-        <When Condition="$([System.Environment]::GetEnvironmentVariable('GITHUB_ACTIONS')) == 'true'">
-            <PropertyGroup>
-                <DefineConstants>$(DefineConstants);GITHUB_ACTIONS;</DefineConstants>
-            </PropertyGroup>
-        </When>
-        <Otherwise>
-        </Otherwise>
-    </Choose>
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" />
+    <PackageReference Include="MSTest.TestAdapter" />
+    <PackageReference Include="MSTest.TestFramework" />
+    <PackageReference Include="SixLabors.ImageSharp" />
+
+    <ProjectReference Include="..\MaaFramework\MaaFramework.csproj" Private="false" />
+    <ProjectReference Include="..\MaaFramework.Binding.Extensions\MaaFramework.Binding.Extensions.csproj" />
+
+    <None Include="..\Common\TestParam.runsettings" />
+    <None Include="SampleResource\**">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
+  </ItemGroup>
+
+  <PropertyGroup>
+    <GenerateProgramFile>false</GenerateProgramFile>
+
+    <AnalysisMode>Default</AnalysisMode>
+    <NoWarn>$(NoWarn),S1121,S1656,S1199,CS1591</NoWarn>
+  </PropertyGroup>
+
+  <!-- Maa Test Constants -->
+  <PropertyGroup>
+    <DefineConstants>$(DefineConstants);MAA_NATIVE;</DefineConstants>
+  </PropertyGroup>
+
+  <Choose>
+    <When Condition="$([System.OperatingSystem]::IsOSPlatform('WINDOWS'))">
+      <PropertyGroup>
+        <DefineConstants>$(DefineConstants);MAA_WIN32;</DefineConstants>
+      </PropertyGroup>
+    </When>
+    <Otherwise>
+    </Otherwise>
+  </Choose>
+
+  <Choose>
+    <When Condition="$([System.Environment]::GetEnvironmentVariable('GITHUB_ACTIONS')) == 'true'">
+      <PropertyGroup>
+        <DefineConstants>$(DefineConstants);GITHUB_ACTIONS;</DefineConstants>
+      </PropertyGroup>
+    </When>
+    <Otherwise>
+    </Otherwise>
+  </Choose>
 
 </Project>
diff --git a/src/MaaFramework.Binding/Buffers/MaaListBuffer.cs b/src/MaaFramework.Binding/Buffers/MaaListBuffer.cs
@@ -35,7 +35,7 @@ public abstract class MaaListBuffer<THandle, T>(THandle invalidHandleValue)
     /// which may cause the underlying std::vector storage to change,
     /// it is necessary to dispose T and increment _version by 1.
     /// </remarks>
-    protected internal int _version;
+    internal int _version;
     /// <inheritdoc/>
     public abstract bool TryAdd(T item);
     /// <inheritdoc/>
diff --git a/src/MaaFramework.Binding/Enums/Binding/ApiInfoFlags.cs b/src/MaaFramework.Binding/Enums/Binding/ApiInfoFlags.cs
@@ -1,6 +1,7 @@
 ﻿namespace MaaFramework.Binding;
 
 #pragma warning disable S2344 // Enumeration type names should not have "Flags" or "Enum" suffixes
+#pragma warning disable CA1711 // 标识符应采用正确的后缀
 
 /// <summary>
 ///     Represents information about binding interoperable API.
diff --git a/src/MaaFramework.Binding/Enums/Binding/InferenceCoreMLFlags.cs b/src/MaaFramework.Binding/Enums/Binding/InferenceCoreMLFlags.cs
@@ -4,6 +4,8 @@
 namespace MaaFramework.Binding;
 
 #pragma warning disable S2344 // Enumeration type names should not have "Flags" or "Enum" suffixes
+#pragma warning disable CA1711 // 标识符应采用正确的后缀
+#pragma warning disable CA2217 // 不要使用 FlagsAttribute 标记枚举
 
 /// <summary>
 ///     InferenceCoreMLFlags are bool options we want to set for CoreML EP.
diff --git a/src/MaaFramework.Binding/Extensions/MaaOptionExtensions.cs b/src/MaaFramework.Binding/Extensions/MaaOptionExtensions.cs
@@ -3,6 +3,7 @@
 namespace MaaFramework.Binding;
 
 #pragma warning disable S4136
+#pragma warning disable CA1707 // 标识符不应包含下划线
 
 /// <summary>
 ///     A static class providing extension methods for setting maa option.
diff --git a/src/MaaFramework.Binding/IMaaTasker.cs b/src/MaaFramework.Binding/IMaaTasker.cs
@@ -45,10 +45,12 @@ public interface IMaaTasker : IMaaCommon, IMaaOption<TaskerOption>, IMaaDisposab
     /// </summary>
     IMaaToolkit Toolkit { get; set; }
 
+#pragma warning disable CA1716 // 标识符不应与关键字匹配
     /// <summary>
     ///     Gets or sets a global.
     /// </summary>
     IMaaGlobal Global { get; set; }
+#pragma warning restore CA1716 // 标识符不应与关键字匹配
 
     /// <summary>
     ///     Gets whether the <see cref="IMaaTasker"/> is fully initialized.
@@ -76,15 +78,19 @@ public interface IMaaTasker : IMaaCommon, IMaaOption<TaskerOption>, IMaaDisposab
     /// <returns><see langword="true"/> if <see cref="IMaaTasker"/> is stopping; otherwise, <see langword="false"/>.</returns>
     bool IsStopping { get; }
 
+#pragma warning disable S1133 // Deprecated code should be removed
+#pragma warning disable CA1716 // 标识符不应与关键字匹配
     /// <summary>
     ///     Stops all appended tasks, the <see cref="IMaaResource"/> and the <see cref="IMaaController"/>. 
     /// </summary>
     /// <returns>A stop job.</returns>
     MaaTaskJob Stop();
 
     /// <inheritdoc cref="Stop"/>
-    [Obsolete("Use Stop() instead.")]
+    [Obsolete("Use Stop() instead.", error: false)]
     MaaTaskJob Abort();
+#pragma warning restore CA1716 // 标识符不应与关键字匹配
+#pragma warning restore S1133 // Deprecated code should be removed
 
     /// <summary>
     ///     Clear the runtime cache.

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public override bool TryIndexOf(MaaStringBuffer item, out MaaSize index)`
`153`	`153`	`for (MaaSize tmpIndex = 0; tmpIndex < count; tmpIndex++)`
`154`	`154`	`{`
`155`	`155`	`if (MaaStringBuffer.TryGetValue(MaaStringListBufferAt(Handle, tmpIndex), out var stringInList)`
`156`		`- && stringInList.Equals(stringInItem))`
	`156`	`+ && stringInList.Equals(stringInItem, StringComparison.Ordinal))`
`157`	`157`	`{`
`158`	`158`	`index = tmpIndex;`
`159`	`159`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,8 @@ public static MaaAgentClient Create(MaaResource resource)`
`61`	`61`	`/// <returns>The <see cref="MaaAgentClient"/> instance.</returns>`
`62`	`62`	`public static MaaAgentClient Create(string identifier, MaaTasker maa)`
`63`	`63`	`{`
	`64`	`+ ArgumentNullException.ThrowIfNull(maa);`
	`65`	`+`
`64`	`66`	`var client = new MaaAgentClient(identifier) { Resource = maa.Resource, };`
`65`	`67`	`_ = MaaAgentClientRegisterTaskerSink(client.Handle, maa.Handle);`
`66`	`68`	`_ = MaaAgentClientRegisterResourceSink(client.Handle, maa.Resource.Handle);`
`@@ -179,6 +181,8 @@ public bool LinkStart(ProcessStartInfo info, CancellationToken cancellationToken`
`179`	`181`	`/// </remarks>`
`180`	`182`	`public bool LinkStart(IMaaAgentClient.AgentServerStartupMethod method, CancellationToken cancellationToken = default)`
`181`	`183`	`{`
	`184`	`+ ArgumentNullException.ThrowIfNull(method);`
	`185`	`+`
`182`	`186`	`if (_agentServerProcess is null or { HasExited: true })`
`183`	`187`	`{`
`184`	`188`	`ArgumentException.ThrowIfNullOrEmpty(Id);`
`@@ -213,7 +217,7 @@ public async Task<bool> LinkStartUnlessProcessExit(Process process, Cancellation`
`213`	`217`	`cts.Token.ThrowIfCancellationRequested();`
`214`	`218`
`215`	`219`	`return completedTask != serverExitTask`
`216`		`- && linkStartTask.Result;`
	`220`	`+ && await linkStartTask;`
`217`	`221`	`}`
`218`	`222`	`finally`
`219`	`223`	`{`
Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,8 @@ public MaaAgentServer Detach()`
`172`	`172`	`}`
`173`	`173`	`}`
`174`	`174`
	`175`	`+#pragma warning disable CA1707 // 标识符不应包含下划线`
	`176`	`+`
`175`	`177`	`/// <summary>`
`176`	`178`	`/// A static class providing extension methods for <see cref="MaaAgentServer"/>.`
`177`	`179`	`/// </summary>`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public class MaaAdbController : MaaController`
`31`	`31`	`/// <exception cref="MaaJobStatusException"/>`
`32`	`32`	`public MaaAdbController(AdbDeviceInfo info, LinkOption link = LinkOption.Start, CheckStatusOption check = CheckStatusOption.ThrowIfNotSucceeded)`
`33`	`33`	`{`
	`34`	`+ ArgumentNullException.ThrowIfNull(info);`
`34`	`35`	`ArgumentException.ThrowIfNullOrEmpty(info.AdbPath);`
`35`	`36`	`ArgumentException.ThrowIfNullOrEmpty(info.AdbSerial);`
`36`	`37`	`ArgumentException.ThrowIfNullOrEmpty(info.Config);`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public class MaaWin32Controller : MaaController`
`31`	`31`	`/// <exception cref="MaaJobStatusException"/>`
`32`	`32`	`public MaaWin32Controller(DesktopWindowInfo info, LinkOption link = LinkOption.Start, CheckStatusOption check = CheckStatusOption.ThrowIfNotSucceeded)`
`33`	`33`	`{`
	`34`	`+ ArgumentNullException.ThrowIfNull(info);`
`34`	`35`	`if (info.Handle == nint.Zero) throw new ArgumentException("Value cannot be zero.", "info.Handle");`
`35`	`36`
`36`	`37`	`var handle = MaaWin32ControllerCreate(info.Handle, (MaaWin32ScreencapMethod)info.ScreencapMethod, (MaaWin32InputMethod)info.MouseMethod, (MaaWin32InputMethod)info.KeyboardMethod);`
Original file line number	Diff line number	Diff line change
`@@ -143,8 +143,10 @@ public bool SetOption<T>(TaskerOption opt, T value)`
`143`	`143`	`#pragma warning restore`
`144`	`144`	`}`
`145`	`145`
	`146`	`+#pragma warning disable CA2213 // 应释放可释放的字段`
`146`	`147`	`private MaaResource _resource = null!;`
`147`	`148`	`private MaaController _controller = null!;`
	`149`	`+#pragma warning restore CA2213 // 应释放可释放的字段`
`148`	`150`
`149`	`151`	`IMaaResource IMaaTasker.Resource`
`150`	`152`	`{`