Skip to content

fix: wlroots use_win32_vk_code method signature#28

Merged
moomiji merged 2 commits into
MaaXYZ:mainfrom
litwak913:fix-wlr
Jul 8, 2026
Merged

fix: wlroots use_win32_vk_code method signature#28
moomiji merged 2 commits into
MaaXYZ:mainfrom
litwak913:fix-wlr

Conversation

@litwak913

@litwak913 litwak913 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

更新 WlRoots 控制器的创建逻辑,接受并传递用于按键输入转换的 Win32 虚拟键模式标志。

新功能:

  • MaaWlRootsController 新增可选参数 useWin32VirtualKeyCodes,用于控制按键码是按 Win32 虚拟键码还是按原始 evdev 码进行解释。

错误修复:

  • 通过添加 use_win32_vk_code 布尔参数,使 MaaWlRootsControllerCreate 的 P/Invoke 签名与原生 API 对齐。

增强项:

  • 扩展 MaaWlRootsController 的调试器显示内容,包含 UseWin32VirtualKeyCodes 标志,以提升调试可见性。
Original summary in English

Summary by Sourcery

Update WlRoots controller creation to accept and propagate a Win32 virtual-key mode flag for key input translation.

New Features:

  • Add an optional useWin32VirtualKeyCodes parameter to MaaWlRootsController to control interpretation of key codes as Win32 virtual-key codes or raw evdev codes.

Bug Fixes:

  • Align the MaaWlRootsControllerCreate P/Invoke signature with the native API by adding the use_win32_vk_code boolean parameter.

Enhancements:

  • Extend MaaWlRootsController debugger display to include the UseWin32VirtualKeyCodes flag for improved debugging visibility.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我已经审查了你的更改,看起来很棒!


Sourcery 对开源项目是免费的——如果你喜欢我们的评审,请考虑分享它们 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@moomiji moomiji merged commit f2fe94c into MaaXYZ:main Jul 8, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants