Skip to content

Commit 3f1aa53

Browse files
committed
chore(js): drop support for connected
1 parent 4896576 commit 3f1aa53

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

source/binding/NodeJS/src/apis/callback.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,11 @@ MaaBool CustomConnect(void* trans_arg)
155155

156156
MaaBool CustomConnected(void* trans_arg)
157157
{
158-
auto customCtx = reinterpret_cast<CustomControllerContext*>(trans_arg);
159-
auto ctx = customCtx->callbacks["connected"];
160-
return ctx->Call<bool>([&](maajs::FunctionType func) { return func.Call({}); });
158+
// auto customCtx = reinterpret_cast<CustomControllerContext*>(trans_arg);
159+
// auto ctx = customCtx->callbacks["connected"];
160+
// return ctx->Call<bool>([&](maajs::FunctionType func) { return func.Call({}); });
161+
std::ignore = trans_arg;
162+
return true;
161163
}
162164

163165
MaaBool CustomRequestUuid(void* trans_arg, MaaStringBuffer* buffer)

source/binding/NodeJS/src/apis/controller.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,8 @@ CustomControllerImpl* CustomControllerImpl::ctor(const maajs::CallbackInfo& info
622622
};
623623

624624
context->add_bind(info.Env(), "connect", "CustomConnect", 0, actor, ret_false);
625-
context->add_bind(info.Env(), "connected", "CustomConnected", 0, actor, ret_true);
625+
// context->add_bind(info.Env(), "connected", "CustomConnected", 0, actor, ret_true);
626+
std::ignore = ret_true;
626627
context->add_bind(info.Env(), "request_uuid", "CustomRequestUuid", 0, actor, ret_null);
627628
context->add_bind(info.Env(), "get_features", "CustomGetFeatures", 0, actor, ret_null);
628629
context->add_bind(info.Env(), "start_app", "CustomStartApp", 1, actor, ret_false);

source/binding/NodeJS/src/apis/controller.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ declare global {
260260

261261
interface CustomControllerActor {
262262
connect?(): maa.MaybePromise<boolean>
263-
connected?(): maa.MaybePromise<boolean>
263+
// connected?(): maa.MaybePromise<boolean>
264264
request_uuid?(): maa.MaybePromise<string | null>
265265
get_features?(): maa.MaybePromise<null | ('mouse' | 'keyboard')[]>
266266
start_app?(intent: string): maa.MaybePromise<boolean>

0 commit comments

Comments
 (0)