Skip to content

fix: use _wfopen for non-ASCII log paths on Windows #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Windsland52 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: use _wfopen for non-ASCII log paths on Windows #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7943ef
fix: use _wfopen for non-ASCII log paths on Windows
Windsland52 May 10, 2026
6114d38
fix: check _wfopen return value to avoid UB
Windsland52 May 10, 2026
bd071e5
fix(logger): report _wfopen failure instead of silent return
Windsland52 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions source/Logger/Logger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#include "MaaUtils/Logger.h"

#include <cerrno>
#include <iostream>
#include <thread>

#ifdef _WIN32
Expand Down Expand Up @@ -197,8 +199,16 @@ void Logger::open(bool append)
#ifdef _WIN32

// https://stackoverflow.com/questions/55513974/controlling-inheritability-of-file-handles-created-by-c-stdfstream-in-window
std::string str_log_path = log_path_.string();
FILE* file_ptr = fopen(str_log_path.c_str(), append ? "a" : "w");
FILE* file_ptr = _wfopen(log_path_.c_str(), append ? L"a" : L"w");
if (!file_ptr) {
const int error_no = errno;
const wchar_t* werr = _wcserror(error_no);
std::cerr << "[MaaUtils][Logger] Failed to open log file: " << path_to_utf8_string(log_path_)
Copy link
Copy Markdown
Member

@MistEO MistEO May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好丑啊，你这还不如不加呢（）

Copy link
Copy Markdown
Member Author

@Windsland52 Windsland52 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那肿么改

<< ", errno=" << error_no
<< ", message=" << (werr ? path_to_utf8_string(werr) : "unknown")
<< std::endl;
return;
}
Comment thread
Windsland52 marked this conversation as resolved.
SetHandleInformation((HANDLE)_get_osfhandle(_fileno(file_ptr)), HANDLE_FLAG_INHERIT, 0);
ofs_ = std::ofstream(file_ptr);
Comment thread
sourcery-ai[bot] marked this conversation as resolved.

Expand Down