Update XADPDFParser.m

[MaddTheSane]

Fix type of PDF's SortPages function.

An alternative is to use NSInteger instead of NSComparisonResult.
This should fix a void cast, most likely used to quiet a warning on OS X/iOS.

[MaddTheSane]

Any feedback on this?

[Copilot]

Pull request overview

This PR corrects the comparator function type used to sort extracted PDF image objects by page order in XADPDFParser, aligning it with the codebase’s established NSComparisonResult comparator pattern and removing an unsafe function-pointer cast.

Changes:

• Updated SortPages to return NSComparisonResult and to use NSOrderedAscending/Descending/Same constants.
• Removed the (void *) cast when passing SortPages to sortUsingFunction:context:.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Krivoblotsky]

Hi @MaddTheSane — sorry this has been sitting without feedback for so long.

The fix to SortPages's return type is a legit correction — using NSComparisonResult is the right type for a comparator. We'll review and merge this. Thank you for the contribution.