Skip to content

Commit 319013a

Browse files
Merge pull request #52 from MacPaw/fix/fix-kernel-type
fix(ApiContext): adjust kernel type to improve compatibility with TerminableInterface
2 parents 113b2ca + 9db56d1 commit 319013a

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

src/Context/ApiContext.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class ApiContext implements Context
2525
private RouterInterface $router;
2626
private RequestStack $requestStack;
2727
private Response $response;
28-
private KernelInterface&TerminableInterface $kernel;
28+
private KernelInterface $kernel;
2929

3030
/**
3131
* @var list<ResetManagerInterface>
@@ -55,7 +55,7 @@ class ApiContext implements Context
5555
public function __construct(
5656
RouterInterface $router,
5757
RequestStack $requestStack,
58-
KernelInterface&TerminableInterface $kernel
58+
KernelInterface $kernel
5959
) {
6060
$this->router = $router;
6161
$this->requestStack = $requestStack;
@@ -182,7 +182,10 @@ private function handleRequestWithKernel(Request $request): Response
182182
$response = $this->kernel->handle($request);
183183

184184
$this->requestStack->pop();
185-
$this->kernel->terminate($request, $response);
185+
186+
if ($this->kernel instanceof TerminableInterface) {
187+
$this->kernel->terminate($request, $response);
188+
}
186189

187190
foreach ($this->resetManagers as $resetManager) {
188191
if ($resetManager->needsReset($request->getMethod())) {

0 commit comments

Comments
 (0)