Fix nil crash in delete_unused_runtimes when a required runtime is missing#63
Merged
Merged
Conversation
nekrich
approved these changes
Mar 4, 2026
nekrich
left a comment
Member
There was a problem hiding this comment.
Nice catch. Thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a crash in
RuntimeHelper#delete_unused_runtimesthat could happen when at least one required runtime is still missing.Problem
delete_unused_runtimesbuiltneeded_simctl_runtimeswithmap.If a required runtime had no match,
simctl_runtime_matching_needed_runtime?returnednil.Later, the code called
needed_simctl_runtime.identifier, which raised:NoMethodError: undefined method 'identifier' for nilChanges
delete_unused_runtimesto usefilter_mapinstead ofmap, so unmatched (nil) runtimes are excluded safely.Validation
bundle exec rspec44 examples, 0 failuresbundle exec rubocop lib/.../runtime_helper.rb spec/.../runtime_helper_spec.rbRisk
Low.
The change is small, isolated, and covered by a regression test.