From 0c3d8f49b70f91cc70955178778472f3c3989a91 Mon Sep 17 00:00:00 2001 From: Aleksey Tupichenkov Date: Fri, 29 Aug 2025 15:31:37 +0300 Subject: [PATCH 1/3] feat: declare BaggageCodec as a service --- config/services.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/config/services.yaml b/config/services.yaml index 2e4c682..8305252 100644 --- a/config/services.yaml +++ b/config/services.yaml @@ -8,6 +8,10 @@ services: public: true shared: true + Macpaw\SchemaContextBundle\Service\BaggageCodec: + public: true + shared: true + Macpaw\SchemaContextBundle\EventListener\BaggageRequestListener: arguments: $baggageSchemaResolver: '@Macpaw\SchemaContextBundle\Service\BaggageSchemaResolver' From 3cc3467e31ba3f6105043b5b97b6fe13374328ff Mon Sep 17 00:00:00 2001 From: Aleksey Tupichenkov Date: Fri, 29 Aug 2025 15:31:54 +0300 Subject: [PATCH 2/3] chore: update readme --- README.md | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 1e7efa9..8367cec 100644 --- a/README.md +++ b/README.md @@ -63,13 +63,22 @@ public function index(BaggageSchemaResolver $schemaResolver) Decorate your http client in your service configuration: ```yaml services: + baggage_aware_payment_http_client: + class: Macpaw\SchemaContextBundle\HttpClient\BaggageAwareHttpClient + decorates: payment_http_client #http client to decorate + arguments: + - '@baggage_aware_payment_http_client.inner' +``` + +### A Note on Testing + +If you are replacing or mocking HTTP clients in your test environment, for example, using a library like [`macpaw/extended-mock-http-client`](https://github.com/MacPaw/extended_mock_http_client), you need to disable the `BaggageAwareHttpClient` decoration. + +```yaml +when@test: + services: baggage_aware_payment_http_client: class: Macpaw\SchemaContextBundle\HttpClient\BaggageAwareHttpClient - decorates: payment_http_client #http client to decorate - arguments: - - '@baggage_aware_payment_http_client.inner' - - '@Macpaw\SchemaContextBundle\Service\BaggageSchemaResolver' - - '@Macpaw\SchemaContextBundle\Service\BaggageCodec' ``` ## Messenger Integration @@ -87,7 +96,7 @@ framework: buses: messenger.bus.default: middleware: - - Macpaw\SchemaContextBundle\Messenger\Middleware\BaggageMiddleware + - Macpaw\SchemaContextBundle\Messenger\Middleware\BaggageSchemaMiddleware ``` ## Testing From 7f46fb3915e2ecf63c321231776ac39787a40338 Mon Sep 17 00:00:00 2001 From: Aleksey Tupichenkov Date: Fri, 29 Aug 2025 17:58:26 +0300 Subject: [PATCH 3/3] fix: fix service declaration --- config/services.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/services.yaml b/config/services.yaml index 8305252..948657d 100644 --- a/config/services.yaml +++ b/config/services.yaml @@ -22,6 +22,6 @@ services: tags: - { name: kernel.event_subscriber } - Macpaw\SchemaContextBundle\Messenger\Middleware\BaggageMiddleware: + Macpaw\SchemaContextBundle\Messenger\Middleware\BaggageSchemaMiddleware: tags: - { name: messenger.middleware }