feat(PLATECO-111): add allowed app names by regular expressions#17
Closed
serhiidonii wants to merge 1 commit into
Closed
feat(PLATECO-111): add allowed app names by regular expressions#17serhiidonii wants to merge 1 commit into
serhiidonii wants to merge 1 commit into
Conversation
serhiidonii
force-pushed
the
feat/PLATECO-111-add-regex-app-names
branch
from
33affbb to
5836d22
Compare
serhiidonii
force-pushed
the
feat/PLATECO-111-add-regex-app-names
branch
from
5836d22 to
0ee1232
Compare
abilyk
approved these changes
Sep 30, 2025
zakhar-huzenko
approved these changes
Sep 30, 2025
alekseytupichenkov
requested changes
Oct 1, 2025
Contributor
There was a problem hiding this comment.
I don't understand why we need this?
Let's imagine the situation:
- the
pr-123service tries to call thestagingservice, but here- the
pr-123service will already havedefault_schema=pr-123 - and this bundle is enabled for
staging - even if
stagingtries to call thepr-456service, everything will still work - the
pr-123service should never receive requests withX-Tenant=pr-456
- the
Moreover, I think there are security problems here in that if you accidentally call the pr-123 service with X-Tenant=staging, you can end up in the wrong tenant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.