Switch random(List) -> shuffle(List) in packages

d-torrance · d-torrance · commit b2d96412ff81 · 2026-04-25T23:00:16.000-04:00
Or sometimes randomSubset
diff --git a/M2/Macaulay2/packages/CodingTheory.m2 b/M2/Macaulay2/packages/CodingTheory.m2
@@ -1790,7 +1790,7 @@ C := linearCode G;
 for i from 1 to 1 do(
     message := transpose matrix {(for n from 1 to numgens target G list(random(R)))};
     codeword := (transpose G)*message;
-    errors := sum take(random entries basis target codeword, 3);
+    errors := sum take(shuffle entries basis target codeword, 3);
     errors = transpose matrix({errors});
     received := codeword+errors;
     decoded := syndromeDecode(C, received, 8);
diff --git a/M2/Macaulay2/packages/CpMackeyFunctors/Tests/BoxProductTests.m2 b/M2/Macaulay2/packages/CpMackeyFunctors/Tests/BoxProductTests.m2
@@ -27,8 +27,8 @@ assert (class (inverse f) ===MackeyFunctorHomomorphism)
 
 -- Test induced map on box products
 for i to 5 do (
-    p = (random {2,3,5,7})#0;
-    n = (random toList (0..20))#0;
+    p = random {2,3,5,7};
+    n = random 21;
     M = makeRandomCpMackeyFunctor(p);
     A = makeBurnsideMackeyFunctor(p);
     timesn = map(A,A,n);
diff --git a/M2/Macaulay2/packages/Cremona.m2 b/M2/Macaulay2/packages/Cremona.m2
@@ -1628,7 +1628,7 @@ genericRestriction = (phi) -> (
    K:=coefficientRing Pn;
    x:=local x;
    H:=K[x_0..x_(n-1)];
-   j:=map(H,Pn,random(toList(x_0..x_(n-1))|{random1 H}));
+   j:=map(H,Pn,shuffle(toList(x_0..x_(n-1))|{random1 H}));
    j=map(H/j(ideal target phi),target phi,toMatrix j);
    phi':=j*phi;
    phi'
diff --git a/M2/Macaulay2/packages/EdgeIdeals.m2 b/M2/Macaulay2/packages/EdgeIdeals.m2
@@ -1038,7 +1038,7 @@ randomUniformHyperGraph (PolynomialRing,ZZ,ZZ) := (R,card,num) -> (
      if card <= 0 then error "cardinalities of hypergraphs must be positive integers";
      if num < 0 then error "number of edges must be nonnegative";
      if num > binomial(numgens R,card) then error "can't make that many edges";
-     edges := take(random subsets(gens R,card),num);
+     edges := take(shuffle subsets(gens R,card),num);
      hyperGraph(R,edges)
      )
 
@@ -1049,7 +1049,7 @@ randomUniformHyperGraph (PolynomialRing,ZZ,ZZ) := (R,card,num) -> (
 -----------------------------------------------------------
 recursiveRandomHyperGraph = (V,L,D,BranchLimit,TerminateTime) -> (
      if #D === 0 then return L;
-     V = random V;
+     V = shuffle V;
      W := set take(V, D#0);
      if any(L, l -> all(W, w-> member(w#0,l))) then return null;
      if any(L, l -> all(l, w-> member(w#0,W))) then return null;
diff --git a/M2/Macaulay2/packages/FastMinors.m2 b/M2/Macaulay2/packages/FastMinors.m2
@@ -345,7 +345,7 @@ chooseRandomNonzeroSubmatrix(ZZ, Matrix) := opts -> (n1, M1) -> (
       --curList = flatten entries curM1;
       entryList = entries transpose matrix nonzeroEntries(curM1);
       if #entryList == 0 then return null;
-      curEntry = entryList#(random(#entryList));
+      curEntry = random entryList;
       --print (curList#curMax);
       curRow = curEntry#0;
       curCol = curEntry#1;
@@ -535,7 +535,7 @@ chooseMinorSmallestDegree(ZZ, MutableMatrix) := o -> (n1, M1) -> (
 randomMaxPosition = method(Options=>{});
 randomMaxPosition(List) := o -> (L1) -> (
     newList := apply(#L1, i -> {L1#i, random((#L1)^2), i});
-    newList2 := random(newList);
+    newList2 := shuffle(newList);
     j := maxPosition(newList2);
     return ((newList2#j)#2);
 );
@@ -544,7 +544,7 @@ randomMaxPosition(List) := o -> (L1) -> (
 randomMinPosition = method(Options=>{});
 randomMinPosition(List) := o -> (L1) -> (
     newList := apply(#L1, i -> {L1#i, random((#L1)^2), i});
-    newList2 := random(newList);
+    newList2 := shuffle(newList);
     j := minPosition(newList2);
     return ((newList2#j)#2);
 );
@@ -553,7 +553,7 @@ randomMinPosition(List) := o -> (L1) -> (
 randomMinPositions = method(Options=>{});
 randomMinPositions(ZZ, List) := o -> (n1, L1) -> (
     newList := apply(#L1, i -> {L1#i, random((#L1)^2), i});
-    newList2 := random(newList);
+    newList2 := shuffle(newList);
     newList3 := sort(newList2);
     return apply(take(n1, newList3), z -> z#0);
 );
@@ -622,10 +622,8 @@ chooseRandomSubmatrix = method(Options=>{});
 
 chooseRandomSubmatrix(ZZ, Matrix) := opts -> (n1, M1) ->
 (
-    rowL := random(toList(0..(numRows M1 - 1)));
-    colL := random(toList(0..(numColumns M1 - 1)));
-    rowL = sort take(rowL, n1);
-    colL = take(colL, n1);
+    rowL := randomSubset(numRows M1, n1);
+    colL := take(shuffle toList(0..<numColumns M1), n1);
     return {rowL, colL};
     )
 
@@ -648,7 +646,7 @@ reorderPolynomialRing(Symbol, Ring) := opts-> (myOrder, R1) -> (
         if (debugLevel > 0) then print "reorderPolynomialRing: it is a polynomialRing";
         coeff := coefficientRing R1;
         genList := generators R1;
-        newGenList := random(genList);
+        newGenList := shuffle(genList);
         return coeff[newGenList, MonomialOrder => myOrder];)
     else (return R1);
 );
diff --git a/M2/Macaulay2/packages/GKMVarieties/Tests_GKMVarieties.m2 b/M2/Macaulay2/packages/GKMVarieties/Tests_GKMVarieties.m2
@@ -8,7 +8,7 @@ Tests for GKMVarieties.m2
 -- flagGeomTuttePolynomial test
 --------------------------------
 TEST ///
-ML = (random drop(drop(allMatroids 4,1),-1))_{0,1}
+ML = (shuffle drop(drop(allMatroids 4,1),-1))_{0,1}
 TML = apply(ML, m -> {tuttePolynomial m, flagGeomTuttePolynomial flagMatroid({m})}) -- 2.5 seconds
 assert all(TML, l -> (map(ring first l, ring last l, gens ring first l))(last l) == first l)
 N = flagMatroid(matrix{{1,1,1},{1,0,0}},{1,2}) 
diff --git a/M2/Macaulay2/packages/IntegralClosure.m2 b/M2/Macaulay2/packages/IntegralClosure.m2
@@ -466,17 +466,14 @@ randomMinors(ZZ,ZZ,Matrix) := (n,d,M) -> (
 	then return (minors(d,M))_*;
      L := {}; -- L will be a list of minors, specified by the pair of lists "rows" and "cols"
      dets := {}; -- the list of determinants taken so far
-     rowlist := toList(0..r-1);
-     collist := toList(0..c-1);
-     ds := toList(0..d-1);
 
      for i from 1 to n do (
       -- choose a random set of rows and of columns, add it to L 
       -- only if it doesn't appear already. When a pair is added to L, 
       -- the corresponding minor is added to "dets"
        while ( 
-         rows := sort (random rowlist)_ds ;
-         cols := sort (random collist)_ds ;
+         rows := randomSubset(r, d);
+         cols := randomSubset(c, d);
          for p in L do (if (rows,cols) == p then break true);
          false)
         do();
@@ -493,13 +490,10 @@ nonzeroMinor(ZZ,Matrix) :=  opts -> (d,M) -> (
      c := numcols M;
      if d > min(r,c) then return null;
      candidate := 0_(ring M);
-     rowlist := toList(0..r-1);
-     collist := toList(0..c-1);
-     ds := toList(0..d-1);
      for i from 1 to opts.Limit do(
       -- choose a random set of rows and of columns, test the determinant.
-         rows := sort (random rowlist)_ds ;
-         cols := sort (random collist)_ds ;
+         rows := randomSubset(r, d);
+         cols := randomSubset(c, d);
          candidate = det (M^rows_cols);
 	 if candidate != 0 then return(candidate);
        );
diff --git a/M2/Macaulay2/packages/Macaulay2Doc/ov_threads.m2 b/M2/Macaulay2/packages/Macaulay2Doc/ov_threads.m2
@@ -41,7 +41,7 @@ Node
     including cpu caches; it is like running Macaulay2 on a computer that is running other big
     programs at the same time. We can see this using @ TO "elapsedTime" @.
   Example
-       L = random toList (1..10000);
+       L = shuffle toList (1..10000);
        elapsedTime         apply(1..100, n -> sort L);
        elapsedTime parallelApply(1..100, n -> sort L);
   Text
diff --git a/M2/Macaulay2/packages/Matroids.m2 b/M2/Macaulay2/packages/Matroids.m2
@@ -747,7 +747,7 @@ relabel (Matroid, List) := Matroid => (M, perm) -> (
 )
 relabel Matroid := Matroid => M -> (
 	E := toList(0..<#M_*);
-	relabel(M, (transpose{E, random E})/toSequence//hashTable)
+	relabel(M, (transpose{E, shuffle E})/toSequence//hashTable)
 )
 
 -- Recursively finds all permutations inducing a bijection on circuits (note: permutations(10) is already slow on a typical machine)
diff --git a/M2/Macaulay2/packages/MultiprojectiveVarieties.m2 b/M2/Macaulay2/packages/MultiprojectiveVarieties.m2
@@ -1000,7 +1000,7 @@ line (EmbeddedProjectiveVariety,EmbeddedProjectiveVariety) := (X,p) -> (
     if dim V >= 2 then return linearSpan {p,point V};
     L := select(decompose V,l -> dim l == 1 and degree l == 1);
     if # L == 0 then error("failed to find line in "|toString(? X));
-    first random L    
+    random L
 );
 line (EmbeddedProjectiveVariety,ZZ) := (X,n) -> (
     L := try line(X,point X) else null;
diff --git a/M2/Macaulay2/packages/Permutations/Tests/mainTests.m2 b/M2/Macaulay2/packages/Permutations/Tests/mainTests.m2
@@ -11,7 +11,7 @@ TEST ///
     assert(not isWellDefined permutation {})
     assert(not isWellDefined permutation {0})
     assert(not isWellDefined permutation toList (0..8))
-    assert(not isWellDefined permutation random toList (0..8))
+    assert(not isWellDefined permutation shuffle toList (0..8))
     assert(not isWellDefined permutation {1,1,2})
 ///
 
diff --git a/M2/Macaulay2/packages/Permutations/Tests/operationsTests.m2 b/M2/Macaulay2/packages/Permutations/Tests/operationsTests.m2
@@ -217,7 +217,7 @@ TEST ///
     -------
     -- Misc
     -------
-    p = permutation random toList (1..10)
+    p = permutation shuffle toList (1..10)
     assert((inverse p)*p == trimmedIdentity)
     assert(p*(inverse p) == trimmedIdentity)
     assert(ord p == ord inverse p)
diff --git a/M2/Macaulay2/packages/PieriMaps.m2 b/M2/Macaulay2/packages/PieriMaps.m2
@@ -90,7 +90,7 @@ isStandard = T -> (
 -- entries (ignoring that some entries might be equal). The output is given in 
 -- the form a hash table where the keys are the resulting tableau and the 
 -- values are -1
-shuffle(List, ZZ, ZZ, ZZ) := (T, col, row1, row2) -> (
+shuffle' = (T, col, row1, row2) -> (
      len1 := #(T#row1);
      len2 := #(T#row2);
      truncatedrow1 := (T#row1)_{0..col-2}; -- grab row1 entries
@@ -118,7 +118,7 @@ shuffle(List, ZZ, ZZ, ZZ) := (T, col, row1, row2) -> (
 towardStandard = T -> (
      x := isStandard T;
      if x === null then return new HashTable from {T=>1};
-     H := new MutableHashTable from shuffle(T, x#1+1, x#0, x#0+1);
+     H := new MutableHashTable from shuffle'(T, x#1+1, x#0, x#0+1);
      if H #? T then (
 	  coeff := -(H#T) + 1;
 	  remove(H,T);
diff --git a/M2/Macaulay2/packages/RandomIdeals.m2 b/M2/Macaulay2/packages/RandomIdeals.m2
@@ -73,7 +73,7 @@ randomMonomialIdeal(List, Ring) := Ideal => (L,S)->(
      Ls := apply(Lu, t -> #positions(L, s->(s==t)));
      --handle the initial degree
      M := flatten entries basis(Lu#0, S^1);
-     if Ls#0 < #M then I := ideal((random M)_{0..Ls#0-1})
+     if Ls#0 < #M then I := ideal((shuffle M)_{0..Ls#0-1})
 	  else (
 	       I = ideal(M);
        	       <<"***** there are only " 
@@ -86,7 +86,7 @@ randomMonomialIdeal(List, Ring) := Ideal => (L,S)->(
      --now the rest of the degrees, if any.
      for t from 1 to #Lu-1 do (
 	  M = flatten entries compress (basis(Lu#t,S^1) % I);
-	  if Ls#t < #M then I = I+ideal((random M)_{0..Ls#t-1})
+	  if Ls#t < #M then I = I+ideal((shuffle M)_{0..Ls#t-1})
 	  else (
 	       if #M=!=0 then I = I+ideal(M);
 	       print("low degree gens generated everything"); 
@@ -112,15 +112,15 @@ randomSquareFreeMonomialIdeal(List, Ring) := Ideal => (L,S)->(
      Lu := sort unique L;
      Ls := apply(Lu, t -> #positions(L, s->(s==t)));
      M := flatten entries gens squareFree(Lu#0, S);
-     if Ls#0 < #M then I := ideal((random M)_{0..Ls#0-1})
+     if Ls#0 < #M then I := ideal((shuffle M)_{0..Ls#0-1})
 	  else (I = ideal(M);
 	       <<"***** there are only " <<binomial(numgens S,Lu#0)<<
 		    " square-free monomials of degree " << Lu#0 <<endl;
 	       return I
 	       );
      for t from 1 to #Lu-1 do (
 	  M=flatten entries compress (gens squareFree(Lu#t,S) % I);
-	  if Ls#t < #M then I = I+ideal((random M)_{0..Ls#t-1})
+	  if Ls#t < #M then I = I+ideal((shuffle M)_{0..Ls#t-1})
 	  else (if #M=!=0 then I = I+ideal(M);
 	       print("low degree gens generated everything");
 	       break
diff --git a/M2/Macaulay2/packages/RandomMonomialIdeals.m2 b/M2/Macaulay2/packages/RandomMonomialIdeals.m2
@@ -355,7 +355,7 @@ randomMonomialSet (PolynomialRing,ZZ,ZZ) := List => o -> (R,D,M) -> (
     if M<0 then stderr << "warning: M expected to be a nonnegative integer" << endl;
     if o.Strategy === "Minimal" then error "Minimal not implemented for fixed size ER model";
     allMonomials := flatten flatten apply(toList(1..D),d->entries basis(d,R));
-    C := take(random(allMonomials), M);
+    C := take(shuffle(allMonomials), M);
     if C==={} then {0_R} else C
 )
 
@@ -376,12 +376,12 @@ randomMonomialSet (PolynomialRing,ZZ,List) := List => o -> (R,D,pOrM) -> (
         if o.Strategy === "Minimal" then (
             currentRingM := R;
             apply(D, d->(
-                chosen := take(random(flatten entries basis(d+1, currentRingM)), pOrM_d);
+                chosen := take(shuffle(flatten entries basis(d+1, currentRingM)), pOrM_d);
                 B = flatten append(B, chosen/(i->sub(i, R)));
                 currentRingM = currentRingM/promote(ideal(chosen), currentRingM)
 		)
 	    )
-	) else B = flatten apply(toList(1..D), d->take(random(flatten entries basis(d,R)), pOrM_(d-1)));
+	) else B = flatten apply(toList(1..D), d->take(shuffle(flatten entries basis(d,R)), pOrM_(d-1)));
     ) else if all(pOrM,q->instance(q,RR)) then (
         if any(pOrM,q-> q<0.0 or 1.0<q) then error "pOrM expected to be a list of real numbers between 0.0 and 1.0";
         if o.Strategy === "Minimal" then (
diff --git a/M2/Macaulay2/packages/RandomPoints.m2 b/M2/Macaulay2/packages/RandomPoints.m2
@@ -423,7 +423,7 @@ getRandomLinearForms(Ring, List) := opts -> (R1, L1) ->(
     if (d <= 0) then (
         
     );
-    tempList := random genList;
+    tempList := shuffle genList;
     if (opts.Verify) then (
         if (#tempList < monomialForms + trueMonomialForms + binomialForms) then (tempList = tempList | apply(monomialForms + trueMonomialForms + binomialForms - #tempList, i->(genList)#(random d)));
     );
@@ -471,7 +471,7 @@ getRandomLinearForms(Ring, List) := opts -> (R1, L1) ->(
     );
     formList = formList | apply(constForms, i -> random(0, R1));
 
-    return random formList;
+    return shuffle formList;
 );
 
 
@@ -845,7 +845,7 @@ linearIntersectionNew(ZZ, Ideal) := opts -> (n1, I1) -> (
                 if ((not homogFlag) and ((fastDim0(workingIdeal) == true))) then (--if we are using decompose
                     if opts.Verbose or debugLevel > 0 then print("linearIntersectionNew: We found at least one point");
                     
-                    ptList = random decompose trim (workingIdeal);                        
+                    ptList = shuffle decompose trim (workingIdeal);
                     if opts.Verbose or debugLevel > 0 then print("linearIntersectionNew: We found " | toString(#ptList) | " points.");
                     j=0;
                     sortedPtList = sort apply(#ptList, t -> {0, degree (ptList#t), t});                    
@@ -862,7 +862,7 @@ linearIntersectionNew(ZZ, Ideal) := opts -> (n1, I1) -> (
                             I3 = psi(I2);
                             newS2 = target psi;
                             m2 = psi(ptList#j);
-                            newPtList = random decompose(m2); --make sure we are picking points randomly from this decomposition
+                            newPtList = shuffle decompose(m2); --make sure we are picking points randomly from this decomposition
                             --since these points are going to be conjugate, we only pick 1.                      
                             if (#newPtList > 0) then ( 
                                 finalPoint = idealToPoint(newPtList#0);
@@ -1391,7 +1391,7 @@ findANonZeroMinor(ZZ, Matrix, Ideal) := opts -> (n,M,I)->(
     Mcolumnextract = M_N1;
     M11 := mutableMatrix phi(Mcolumnextract);
     N2 = (rowRankProfile(M11));
-    N1rand := random(N1);
+    N1rand := shuffle(N1);
     N1new = {};
     for i from  0 to n-1 do(
 	    N1new = join(N1new, {N1rand#i});
@@ -1401,7 +1401,7 @@ findANonZeroMinor(ZZ, Matrix, Ideal) := opts -> (n,M,I)->(
     if (rank(M3)<n) then error "findANonZeroMinor:  Something went wrong, the matrix rank fell taking the first submatrix.  This indicates a bug in the program.";
     --this is what was written before:
     --return (P,N1,N2,"findANonZeroMinor: Using the second and third outputs failed to generate a random matrix of the given size, that has full rank when evaluated at the first output.");
-    N2rand := random(rowRankProfile(M3));
+    N2rand := shuffle(rowRankProfile(M3));
     N2new = {};
     for i from 0 to n-1 do(
         N2new = join(N2new, {N2rand#i});
diff --git a/M2/Macaulay2/packages/RationalPoints2.m2 b/M2/Macaulay2/packages/RationalPoints2.m2
@@ -73,7 +73,7 @@ pow = (n, lst) -> (
 -- Utility function that shuffles two list u and v according to a list ind
 -- of indices in 0 (for u) and 1 (for v)
 --
-shuffle = (ind, u, v) -> (
+shuffle' = (ind, u, v) -> (
     (i,j) := (-1,-1);
     return for k in (0..<#ind) list if ind_k==0 then (i=i+1; u_i) else (j=j+1; v_j);
 );
@@ -759,7 +759,7 @@ rationalPoints(Ideal) := opts -> I -> (
                 unusedR := k(monoid[x_{0..<unused}]);
                 R = k(monoid[x_{0..<n-unused}]);
                 x = gens R;
-                I = (map(R, ring I, shuffle(ind, (unused:0), x))) I;
+                I = (map(R, ring I, shuffle'(ind, (unused:0), x))) I;
             );
             -- enumeration of points and post-processing
             if PROJECTIVE then ( -- projective case
@@ -769,17 +769,17 @@ rationalPoints(Ideal) := opts -> I -> (
                     if AMOUNT then result = result*(#ELS)^unused+((#ELS)^unused-1)//(#ELS-1)
                     else (
                         -- shuffle and homogenize so that the first non-zero coordinate is 1
-                        result = flatten table(pow_unused ELS, result, homogCoord @@ shuffle_ind);
+                        result = flatten table(pow_unused ELS, result, homogCoord @@ shuffle'_ind);
                         -- extra points lying in a projective subspace
                         PP := findProjPoints(ideal 0_unusedR);
-                        result = result | PP / (x->homogCoord shuffle(ind, x, ((n-unused):0_k)));
+                        result = result | PP / (x->homogCoord shuffle'(ind, x, ((n-unused):0_k)));
                     );
                 );
             ) else ( -- affine case
                 result = findPoints I;
                 if unused > 0 then ( -- reconstruction
                     if AMOUNT then result = result*(#ELS)^unused
-                    else result = flatten table(pow_unused ELS, result, shuffle_ind);
+                    else result = flatten table(pow_unused ELS, result, shuffle'_ind);
                 );
             );
         ) else ( -- number field
diff --git a/M2/Macaulay2/packages/RelativeCanonicalResolution.m2 b/M2/Macaulay2/packages/RelativeCanonicalResolution.m2
@@ -181,7 +181,7 @@ balancedPartition (ZZ,ZZ) := (n,m) -> ( -- m items list of length n
       (L,L1) := ({},{});
       PHI := matrix map(S^1,S^1,0_S);
       while (#flatten entries PHI < g) do (
-      pts := random(apply(p,i -> matrix{{i,1}})|{matrix{{1,0}}});
+      pts := shuffle(apply(p,i -> matrix{{i,1}})|{matrix{{1,0}}});
       while (#L < g or #(unique flatten L) < #(flatten L)) do (  
              (L,L1) = ({},{}); 
 	     f := random(S^1, S^{2:-k});
diff --git a/M2/Macaulay2/packages/Resultants.m2 b/M2/Macaulay2/packages/Resultants.m2
diff --git a/M2/Macaulay2/packages/SchurComplexes.m2 b/M2/Macaulay2/packages/SchurComplexes.m2
diff --git a/M2/Macaulay2/packages/SchurFunctors.m2 b/M2/Macaulay2/packages/SchurFunctors.m2
diff --git a/M2/Macaulay2/packages/SpaceCurves.m2 b/M2/Macaulay2/packages/SpaceCurves.m2
diff --git a/M2/Macaulay2/packages/SparseResultants.m2 b/M2/Macaulay2/packages/SparseResultants.m2
diff --git a/M2/Macaulay2/packages/Tableaux/algorithms.m2 b/M2/Macaulay2/packages/Tableaux/algorithms.m2
diff --git a/M2/Macaulay2/packages/VirtualResolutions.m2 b/M2/Macaulay2/packages/VirtualResolutions.m2

Original file line number	Diff line number	Diff line change
`@@ -747,7 +747,7 @@ relabel (Matroid, List) := Matroid => (M, perm) -> (`
`747`	`747`	`)`
`748`	`748`	`relabel Matroid := Matroid => M -> (`
`749`	`749`	`E := toList(0..<#M_*);`
`750`		`- relabel(M, (transpose{E, random E})/toSequence//hashTable)`
	`750`	`+ relabel(M, (transpose{E, shuffle E})/toSequence//hashTable)`
`751`	`751`	`)`
`752`	`752`
`753`	`753`	`-- Recursively finds all permutations inducing a bijection on circuits (note: permutations(10) is already slow on a typical machine)`