Add Padic package#4213
Merged
Merged
Conversation
d-torrance
added
the
waiting for another PR
mahrud
reviewed
Apr 26, 2026
d-torrance
force-pushed
the
padic
branch
4 times, most recently
from
d55597f to
a8e8d8a
Compare
Member
Author
|
Discussed with Mike. Will merge after fixing conflicts |
d-torrance
removed
the
waiting for another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package adds p-adic number support using FLINT and the ForeignFunctions package. Preprint at https://arxiv.org/abs/2604.16799
This is on top of #4204, as it depends on some of the changes to the Valuations package.
I also need to flesh out the documentation and probably add some more tests.Done!AI Disclosure
Much of the documentation and a number of the tests were originally written using Claude Code, although I reviewed them and made a number of modifications.