Use engine for all debug build code#4241
Merged
Merged
Conversation
This way we have it for the standalone engine but don't get multiple definition errors when we link with the interpreter.
Member
Author
|
Even though only 25% of the builds passed, I think this is in good shape as we got a functioning debug version of M2 in each case, and each of them chugged along for over 2 hours before running into a known memory issue (#1064, #1539, #2162): https://github.com/Macaulay2/M2/actions/runs/25199464796 |
Member
|
I'm good as long as the binary actually compiled. |
Member
Author
|
Discussed with Mike |
This was referenced May 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we have it for the standalone engine but don't get multiple definition errors when we link with the interpreter.
We also fix a couple out of bounds errors in the interpreter that fired after I got the debug build working. (#3938)
Closes: #4164
Draft for now to test the GitHub debug builds.