Skip to content

Rework logprobs multiple choice solvers #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianbulovic wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Rework logprobs multiple choice solvers #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24c5e17
rework logprobs solvers
ianbulovic Jan 13, 2026
51f0401
squeeze prefix logprobs to be one-dimensional
ianbulovic Jan 13, 2026
a459217
add docstrings
ianbulovic Jan 13, 2026
65be1d8
fix attn mask
ianbulovic Jan 13, 2026
73a8007
support mockllm for logprobs generators
ianbulovic Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/cnlp_llm/eval/solvers/logprobs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
from .letters import letter_prob_multiple_choice
from .logprobs_generator import BatchedLogprobsGenerator
from .sequences import seq_prob_multiple_choice

__all__ = ["letter_prob_multiple_choice", "seq_prob_multiple_choice"]
__all__ = [
"BatchedLogprobsGenerator",
"letter_prob_multiple_choice",
"seq_prob_multiple_choice",
]
6 changes: 3 additions & 3 deletions src/cnlp_llm/eval/solvers/logprobs/letters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def letter_prob_multiple_choice(model: str | Model | None = None) -> Solver:
async def solve(state: TaskState, generate: Generate) -> TaskState:
nonlocal generator
if generator is None:
generator = BatchedLogprobsGenerator(get_model(model))
generator = BatchedLogprobsGenerator.from_model(get_model(model))

if not state.choices:
raise ValueError(
Expand All @@ -52,8 +52,8 @@ async def solve(state: TaskState, generate: Generate) -> TaskState:
ChatMessageAssistant(content=f"ANSWER: {letter}") for letter in letters
]

choice_probs = await generator.compare_logprobs(
choice_messages, prepend=state.messages
choice_probs = await generator.get_choice_logprobs(
prefix=state.messages, choices=choice_messages
)

ranked = sorted(
Expand Down
Loading