fix: align release healthcheck with sdk workflow

Author: MackDing

.github/workflows/ci.yml

@@ -18,6 +18,7 @@ jobs:
     env:
       BOT_TOKEN: "ci-bot-token"
       ALLOWED_USER_IDS: "1"
+      CODEX_BACKEND: "sdk"
       CODEX_COMMAND: "node"
       CODEX_WORKDIR: "."
       WORKSPACE_ROOT: "."

.github/workflows/release.yml

@@ -17,6 +17,7 @@ jobs:
     env:
       BOT_TOKEN: "ci-bot-token"
       ALLOWED_USER_IDS: "1"
+      CODEX_BACKEND: "sdk"
       CODEX_COMMAND: "node"
       CODEX_WORKDIR: "."
       WORKSPACE_ROOT: "."

docs/release.md

@@ -38,7 +38,7 @@ Manual checks:
 git checkout main
 git pull --ff-only
 BOT_TOKEN=dummy-token ALLOWED_USER_IDS=1 npm run release:check
-git tag v0.2.0
+git tag v0.2.1
 git push origin main --tags
 ```
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "codex-telegram-claws",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "A super Telegram bot that securely orchestrates Codex via SDK or CLI/PTy streaming, MCP routing, and GitHub automation skills.",
   "type": "module",
   "main": "src/index.ts",

package.json

@@ -3,7 +3,10 @@ import { spawn } from "node:child_process";
 import path from "node:path";
 import process from "node:process";
 import type { AppConfig } from "../config.js";
-import { repairNodePtySpawnHelperPermissions } from "../runner/ptyPreflight.js";
+import {
+  repairNodePtySpawnHelperPermissions,
+  type ExecutablePermissionResult
+} from "../runner/ptyPreflight.js";
 import { extractCodexExecResponse } from "../bot/formatter.js";
 import { toErrorMessage } from "../lib/errors.js";
 
@@ -39,6 +42,7 @@ interface HealthcheckOptions {
   telegramLiveCheck?: boolean;
   codexLiveCheck?: boolean;
   codexLiveRunner?: (config: AppConfig) => Promise<CodexLiveCheckResult>;
+  ptyHelperProbe?: () => ExecutablePermissionResult;
 }
 
 interface TelegramGetMeResponse {
@@ -258,21 +262,30 @@ export async function runHealthcheck(
         )
   );
 
-  const ptyHelper = repairNodePtySpawnHelperPermissions();
-  if (ptyHelper.error) {
-    checks.push(
-      makeCheck("node-pty helper", strict ? "fail" : "warn", ptyHelper.error)
-    );
-  } else if (ptyHelper.changed) {
+  if (config.runner.backend === "sdk") {
     checks.push(
-      makeCheck(
-        "node-pty helper",
-        "pass",
-        `Repaired execute permissions: ${ptyHelper.path}`
-      )
+      makeCheck("node-pty helper", "pass", "Not required for sdk backend.")
     );
   } else {
-    checks.push(makeCheck("node-pty helper", "pass", ptyHelper.path));
+    const ptyHelperProbe =
+      options.ptyHelperProbe || repairNodePtySpawnHelperPermissions;
+    const ptyHelper = ptyHelperProbe();
+
+    if (ptyHelper.error) {
+      checks.push(
+        makeCheck("node-pty helper", strict ? "fail" : "warn", ptyHelper.error)
+      );
+    } else if (ptyHelper.changed) {
+      checks.push(
+        makeCheck(
+          "node-pty helper",
+          "pass",
+          `Repaired execute permissions: ${ptyHelper.path}`
+        )
+      );
+    } else {
+      checks.push(makeCheck("node-pty helper", "pass", ptyHelper.path));
+    }
   }
 
   const liveTelegramCheck = Boolean(options.telegramLiveCheck);

src/ops/healthcheck.ts

@@ -175,3 +175,58 @@ test("runHealthcheck reports a failing live Codex probe when the backend check f
     true
   );
 });
+
+test("runHealthcheck does not fail strict mode on sdk backend when node-pty helper is unavailable", async () => {
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), "claws-health-"));
+  const config = createConfig(root);
+
+  const result = await runHealthcheck(config, {
+    env: process.env,
+    strict: true,
+    ptyHelperProbe: () => ({
+      path: "",
+      changed: false,
+      executable: false,
+      error: "missing helper"
+    })
+  });
+
+  assert.equal(result.ok, true);
+  assert.equal(
+    result.checks.some(
+      (check) =>
+        check.name === "node-pty helper" &&
+        check.status === "pass" &&
+        check.detail.includes("sdk backend")
+    ),
+    true
+  );
+});
+
+test("runHealthcheck still fails strict mode on cli backend when node-pty helper is unavailable", async () => {
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), "claws-health-"));
+  const config = createConfig(root);
+  config.runner.backend = "cli";
+
+  const result = await runHealthcheck(config, {
+    env: process.env,
+    strict: true,
+    ptyHelperProbe: () => ({
+      path: "",
+      changed: false,
+      executable: false,
+      error: "missing helper"
+    })
+  });
+
+  assert.equal(result.ok, false);
+  assert.equal(
+    result.checks.some(
+      (check) =>
+        check.name === "node-pty helper" &&
+        check.status === "fail" &&
+        check.detail.includes("missing helper")
+    ),
+    true
+  );
+});