refactor: align View() and SetSize() patterns across UI models

Extract chromeHeight() helpers in pager and menu to match the
resourcelist pattern. Unify View() to build a `bottom` variable
with conditional help inclusion and a single return.

Author: MacroPower

pkg/ui/menu/menu.go

@@ -142,11 +142,17 @@ func (m Model) submitResults(ctx context.Context) tea.Cmd {
 }
 
 func (m Model) View() string {
+	statusBar := m.statusBarView()
+
+	bottom := statusBar
+	if m.Help.Visible() {
+		bottom = lipgloss.JoinVertical(lipgloss.Left, statusBar, m.helpView())
+	}
+
 	return lipgloss.JoinVertical(
 		lipgloss.Left,
 		m.configeditor.View(),
-		m.statusBarView(),
-		m.helpView(),
+		bottom,
 	)
 }
 
@@ -156,17 +162,24 @@ func (m Model) statusBarView() string {
 	return m.statusBar.RenderWithNote("menu", m.theme.Ellipsis)
 }
 
+const statusBarHeight = 1
+
+func (m Model) chromeHeight() int {
+	helpHeight := m.Help.Height()
+	if helpHeight > 0 {
+		helpHeight++ // Account for separator line between status bar and help.
+	}
+
+	return statusBarHeight + helpHeight
+}
+
 func (m *Model) SetSize(w, h int) tea.Cmd {
 	m.width = w
 	m.height = h
 	m.Help.SetWidth(w)
 	m.statusBar.SetWidth(w)
 
-	if helpH := m.Help.Height(); helpH > 0 {
-		m.configeditor.SetHeight(h - helpH - 2)
-	} else {
-		m.configeditor.SetHeight(h - 1)
-	}
+	m.configeditor.SetHeight(h - m.chromeHeight())
 
 	return nil
 }

pkg/ui/pager/pager.go

@@ -192,41 +192,39 @@ func (m *Model) Update(msg tea.Msg) tea.Cmd {
 }
 
 func (m Model) View() string {
+	var bottomBar string
 	if m.ViewState == StateSearching {
-		return lipgloss.JoinVertical(
-			lipgloss.Top,
-			m.viewport.View(),
-			m.searchBarView(),
-			m.helpView(),
-		)
+		bottomBar = m.searchBarView()
+	} else {
+		bottomBar = m.statusBarView()
+	}
+
+	bottom := bottomBar
+	if m.Help.Visible() {
+		bottom = lipgloss.JoinVertical(lipgloss.Top, bottomBar, m.helpView())
 	}
 
 	return lipgloss.JoinVertical(
 		lipgloss.Top,
 		m.viewport.View(),
-		m.statusBarView(),
-		m.helpView(),
+		bottom,
 	)
 }
 
+func (m Model) chromeHeight() int {
+	return statusBarHeight + m.Help.Height()
+}
+
 func (m *Model) SetSize(w, h int) tea.Cmd {
 	m.width = w
 	m.height = h
 	m.Help.SetWidth(w)
 	m.statusBar.SetWidth(w)
 
-	// Calculate viewport dimensions.
-	viewportHeight := h - statusBarHeight
-
-	// Subtract help height if visible.
-	if helpH := m.Help.Height(); helpH > 0 {
-		viewportHeight -= (statusBarHeight + helpH)
-	}
-
 	m.searchInput.SetWidth(w - ansi.StringWidth(m.searchInput.Prompt))
 
 	m.viewport.SetWidth(w)
-	m.viewport.SetHeight(viewportHeight)
+	m.viewport.SetHeight(h - m.chromeHeight())
 
 	return nil
 }