Migrate to the PowerIO parser backend for broad non-MATPOWER format support#50
Open
samtalki wants to merge 1 commit into
Open
Migrate to the PowerIO parser backend for broad non-MATPOWER format support#50samtalki wants to merge 1 commit into
samtalki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR routes ExaModelsPower parsing through PowerIO.
This PR's branch currently retains ExaPowerIO as a dependency for PGLib artifact lookup, pending the guidance of @hfytr, @sshin23, @frapac .
The main change that this PR offers is broad format compatibility for ExaModelsPower beyond MATPOWER: through PowerIO, ExaModelsPower immediately supports PSS/E
.raw, PowerWorld.aux, PSLF.epc, PowerModels.json, and more.PowerIO has also already shipped distribution systems support as of v0.3.0 through the
powerio-distcrate, creating a straightforward pathway for future distribution systems support in ExaModelsPower. (note that PowerIO has already been adopted as a dependency by BMOPFTools.jl)At the same time, this PR branch is smaller than the current parser path.
Changes:
frompassthrough for ambiguous .json formats such as PowerModels vs. EgretCurrent checks:
Pkg.test("ExaModelsPower")passed locallycc @hfytr: ExaPowerIO’s fantastic
PowerDatalayout made this integration extremely straightforward. I would greatly value your review and expertise on this, and I would be happy to coordinate on the parser surface in PowerIO as well.Unrelated Aside
The full local ExaModelsPower test suite passed, but took >25 minutes on my machine. Is this expected behavior?