Correcting ruff

Author: Maffooch

dojo/api_v2/serializers.py

@@ -113,17 +113,17 @@
     Vulnerability_Id_Template,
     get_current_date,
 )
+from dojo.product_announcements import (
+    LargeScanSizeProductAnnouncement,
+    ScanTypeProductAnnouncement,
+)
 from dojo.tools.factory import (
     get_choices_sorted,
     requires_file,
     requires_tool_type,
 )
 from dojo.user.utils import get_configuration_permissions_codenames
 from dojo.utils import is_scan_file_too_large, tag_validator
-from dojo.product_announcements import (
-    LargeScanSizeProductAnnouncement,
-    ScanTypeProductAnnouncement,
-)
 
 logger = logging.getLogger(__name__)
 deduplicationLogger = logging.getLogger("dojo.specific-loggers.deduplication")

dojo/product_announcements.py

@@ -6,6 +6,7 @@
 
 
 class ProductAnnouncementManager:
+
     """Base class for centralized helper methods"""
 
     base_try_free = "Try today for free"
@@ -21,9 +22,9 @@ def __init__(
         *args: list,
         request: HttpRequest = None,
         response: HttpResponse = None,
-        response_data: dict = {},
+        response_data: dict | None,
         **kwargs: dict,
-    ) -> None:
+    ):
         """Skip all this if the CREATE_CLOUD_BANNER is not set"""
         if not settings.CREATE_CLOUD_BANNER:
             return
@@ -35,17 +36,17 @@ def __init__(
             )
         elif response is not None and isinstance(response, HttpResponse):
             response.data = self._add_api_response_key(
-                message=f"{self.base_message} {self.api_outreach}", data=response.data
+                message=f"{self.base_message} {self.api_outreach}", data=response.data,
             )
-        elif response_data != {} and isinstance(response_data, dict):
+        elif response_data is not None and isinstance(response_data, dict):
             response_data = self._add_api_response_key(
-                message=f"{self.base_message} {self.api_outreach}", data=response_data
+                message=f"{self.base_message} {self.api_outreach}", data=response_data,
             )
         else:
             msg = "At least one of request, response, or response_data must be supplied"
             raise ValueError(msg)
 
-    def _add_django_message(self, request: HttpRequest, message: str) -> None:
+    def _add_django_message(self, request: HttpRequest, message: str):
         """Add a message to the UI"""
         messages.add_message(
             request=request,
@@ -72,9 +73,9 @@ def __init__(
         *args: list,
         request: HttpRequest = None,
         response: HttpResponse = None,
-        response_data: dict = {},
+        response_data: dict | None,
         **kwargs: dict,
-    ) -> None:
+    ):
         self.base_message = "Pro comes with support."
         super().__init__(
             *args,
@@ -91,10 +92,10 @@ def __init__(
         *args: list,
         request: HttpRequest = None,
         response: HttpResponse = None,
-        response_data: dict = {},
+        response_data: dict | None,
         duration: float = 0.0,  # seconds
         **kwargs: dict,
-    ) -> None:
+    ):
         self.trigger_threshold = 60.0
         minute_duration = round(duration / 60.0)
         self.base_message = f"Your import took about {minute_duration} minute(s). Did you know Pro has async imports?"
@@ -114,10 +115,10 @@ def __init__(
         *args: list,
         request: HttpRequest = None,
         response: HttpResponse = None,
-        response_data: dict = {},
+        response_data: dict | None,
         duration: float = 0.0,  # seconds
         **kwargs: dict,
-    ) -> None:
+    ):
         self.trigger_threshold = 15.0
         self.base_message = "Did you know, Pro has a new UI and is performance tested up to 22M findings?"
         if duration > self.trigger_threshold:
@@ -149,10 +150,10 @@ def __init__(
         *args: list,
         request: HttpRequest = None,
         response: HttpResponse = None,
-        response_data: dict = {},
-        scan_type: str = None,
+        response_data: dict | None,
+        scan_type: str | None,
         **kwargs: dict,
-    ) -> None:
+    ):
         self.base_message = (
             f"Did you know, Pro has an automated no-code connector for {scan_type}?"
         )