Merge pull request #158 from KristjanESPERANTO/linter

Okay, I'm merging this PR 🙂

Author: KristjanESPERANTO

.eslintrc.json

@@ -0,0 +1,29 @@
+{
+  "env": {
+    "es6": true,
+    "browser": true,
+    "commonjs": true,
+    "es2021": true
+  },
+  "extends": ["airbnb-base", "plugin:json/recommended", "prettier"],
+  "parserOptions": {
+    "ecmaVersion": "latest",
+    "sourceType": "module"
+  },
+  "plugins": ["prettier"],
+  "root": true,
+  "globals": {
+    "moment": "readonly"
+  },
+  "rules": {
+    "default-case": "off",
+    "global-require": "off",
+    "prefer-destructuring": "off",
+    "prettier/prettier": "error",
+    "import/no-dynamic-require": "off",
+    "import/no-unresolved": "off",
+    "no-param-reassign": ["error", { "props": true, "ignorePropertyModificationsFor": ["arrs", "calendar", "dom", "e", "payload", "slotDom", "targetDom"] }],
+    "no-plusplus": ["error", { "allowForLoopAfterthoughts": true }],
+    "no-prototype-builtins": "off"
+  }
+}

.github/linters/.eslintrc.js

@@ -1,7 +1,7 @@
 name: Super-Linter
 
 # Run this workflow every time a new commit pushed to your repository
-on: push
+on: [push, pull_request]
 
 jobs:
   # Set the job key. The key is displayed as the job name
@@ -27,11 +27,12 @@ jobs:
         env:
           DEFAULT_BRANCH: main
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          JAVASCRIPT_ES_CONFIG_FILE: .eslintrc.js
+          LINTER_RULES_PATH: /
+          CSS_FILE_NAME: .stylelintrc.json
+          JAVASCRIPT_DEFAULT_STYLE: prettier
+          JAVASCRIPT_ES_CONFIG_FILE: .eslintrc.json
+          JSCPD_CONFIG_FILE: .jscpd.json
           YAML_CONFIG_FILE: .yamllint.yaml
-          # the standard config conflicts heavily with the upstream config.js
-          # hence I opted to disable it
-          VALIDATE_JAVASCRIPT_STANDARD: false
-          # the klaernie example k8s deployment has duplicated segments on purpose (same filter for two seperate calendars, in two config instances).
-          # JSCPD detects these, but they are unavoidable
-          VALIDATE_JSCPD: false
+          # Exclude symlinks because JSCPD has a problem with them
+          # (You could add nore using |. Like this: .*(docs/index.md|filex.js|.filey.yaml).*)
+          FILTER_REGEX_EXCLUDE: .*(docs/index.md).*

.github/workflows/superlinter.yaml

@@ -0,0 +1,5 @@
+{
+  "ignore": [
+    "docs/Configuration/Views/week,-month.md"
+  ]
+}

.jscpd.json

@@ -11,23 +11,13 @@ class CellSlot extends Slot {
     this.makeSlotDomClass(view, daySeq, weekSeq);
   }
 
-  static factory(view, slotPeriods, weekSeq = 0, events) {
-    const slots = [];
-    for (let i = 0; i < slotPeriods.length; i++) {
-      const slot = new CellSlot(view, slotPeriods[i], i, weekSeq);
-      // slot.assign(events)
-      slots.push(slot);
-    }
-    return slots;
-  }
-
   init(view) {
     this.makeDom();
     this.makeSlotHeader(view);
-    this.adjustSlotHeight(view, this.contentDom);
+    CellSlot.adjustSlotHeight(view, this.contentDom);
   }
 
-  adjustSlotHeight(view, dom) {
+  static adjustSlotHeight(view, dom) {
     view.adjustSlotHeight(dom);
   }
 

.github/linters/.stylelintrc.json .stylelintrc.json.github/linters/.stylelintrc.json renamed to .stylelintrc.json

@@ -17,16 +17,14 @@ class Event {
 
   destroy() {
     this.dom.remove();
-    for (const property in this) {
+    this.forEach((property) => {
       if (this.hasOwnProperty(property)) {
         this[property] = null;
       }
-    }
+    });
   }
 
   draw(slot, targetDom) {
-    // eslint-disable-next-line no-unused-vars
-    const useEventTimeRelative = slot.useEventTimeRelative;
     const hideOverflow = slot.hideOverflow;
     const eventDom = this.dom;
     eventDom.style.opacity = 0;
@@ -49,12 +47,12 @@ class Event {
     return 0;
   }
 
-  drawSleeve(slot, sleeve) {
-    // to implement
-  }
+  /* TODO: To implement */
+  /* drawSleeve(slot, sleeve) {
+    ...
+  } */
 
   makeEventDom() {
-    const event = this.data;
     const locale = this.locale;
     const now = moment().locale(locale);
 
@@ -68,6 +66,7 @@ class Event {
       return isMulti;
     };
 
+    const event = this.data;
     const eventDom = document.createElement("div");
     eventDom.classList.add("event");
 

.github/linters/.yamllint.yaml .yamllint.yaml.github/linters/.yamllint.yaml renamed to .yamllint.yaml

@@ -11,7 +11,7 @@ class Scene {
     this.nextUid = uid === sceneLength - 1 ? 0 : uid + 1;
     this.previousUid = uid === 0 ? sceneLength - 1 : uid - 1;
     this.viewNames =
-      !scene.views || scene.views.length == 0
+      !scene.views || scene.views.length === 0
         ? cfgs.views.map((v) => v.name)
         : scene.views;
     this.views = [];
@@ -20,9 +20,9 @@ class Scene {
   draw(events) {
     this.clearViews();
     this.viewNames.forEach((viewName) => {
-      const viewConfig = this.config.views.find((config) => {
-        if (config.name === viewName) return true;
-      });
+      const viewConfig = this.config.views.find(
+        (config) => config.name === viewName
+      );
       viewConfig.sceneClassName = this.className;
       const view = View.makeByName(viewConfig, events);
       if (view) {

CALEXT2_CellSlot.js

@@ -30,11 +30,11 @@ class Slot {
 
   destroy() {
     this.dom.remove();
-    for (const property in this) {
+    this.forEach((property) => {
       if (this.hasOwnProperty(property)) {
         this[property] = null;
       }
-    }
+    });
   }
 
   static factory(view, slotPeriods, events) {
@@ -76,7 +76,7 @@ class Slot {
           event.startHere = true;
         if (eE.isBetween(this.start, this.end, null, "(])"))
           event.endHere = true;
-        if (eE.format("HHmmss") == "000000")
+        if (eE.format("HHmmss") === "000000")
           event.endDate = moment(eE).add(-1, "second").endOf("day").format("X");
         this.events.push(event);
       }