Skip to content

Commit 3eaa4be

Browse files
fix: add existence check for daily rain/snow data
- Check if day.rain/day.snow exist before NaN check - Prevents potential errors when properties are undefined
1 parent 16844f9 commit 3eaa4be

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

MMM-OneCallWeather.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ Module.register("MMM-OneCallWeather", {
220220
let snow = 0;
221221
let precip = false;
222222

223-
if (!Number.isNaN(day.rain)) {
223+
if (day.rain && !Number.isNaN(day.rain)) {
224224
const { rain: dayRain } = day;
225225
if (this.config.units === "imperial") {
226226
rain = dayRain / 25.4;
@@ -230,7 +230,7 @@ Module.register("MMM-OneCallWeather", {
230230
}
231231
precip = true;
232232
}
233-
if (!Number.isNaN(day.snow)) {
233+
if (day.snow && !Number.isNaN(day.snow)) {
234234
const { snow: daySnow } = day;
235235
if (this.config.units === "imperial") {
236236
snow = daySnow / 25.4;

0 commit comments

Comments
 (0)