fix: only flag explicit GitHub zero-watchers

Author: KristjanESPERANTO

scripts/check-modules/__tests__/result-markdown.test.js

@@ -26,6 +26,12 @@ describe("result-markdown", () => {
         maintainer: "Dana",
         url: "https://github.com/example/MMM-Quiet",
         watchersCount: 0
+      },
+      {
+        name: "MMM-NotGitHub",
+        maintainer: "Erin",
+        url: "https://gitlab.com/example/MMM-NotGitHub",
+        watchersCount: 0
       }
     ]);
 

scripts/check-modules/result-markdown.ts

@@ -22,6 +22,20 @@ interface ProcessedModuleLike {
   url?: string;
 }
 
+function isGitHubUrl(url: unknown): boolean {
+  if (typeof url !== "string" || url.length === 0) {
+    return false;
+  }
+
+  try {
+    const host = new URL(url).hostname.toLowerCase();
+    return host === "github.com" || host === "www.github.com";
+  }
+  catch {
+    return false;
+  }
+}
+
 export function normalizeIssuesInput(issues: string[] | string | boolean | null | undefined): string[] {
   if (Array.isArray(issues)) {
     return issues.slice();
@@ -42,7 +56,7 @@ export function collectIssueSummaries(modules: unknown[]): IssueSummary[] {
 
     const stageModule = module as ProcessedModuleLike;
     const issues = normalizeIssuesInput(stageModule.issues);
-    const watcherIssue = stageModule.watchersCount === 0
+    const watcherIssue = isGitHubUrl(stageModule.url) && stageModule.watchersCount === 0
       ? "GitHub reports 0 watchers; maintainer notifications may be missed."
       : null;
 

scripts/collect-metadata/index.ts

@@ -311,6 +311,31 @@ async function fetchIndividualModule(module: EnrichedModule, repoType: string, c
   }
 }
 
+/**
+ * Public fallback for unauthenticated GitHub API rate limits.
+ * GitHub's commits Atom feed is typically still reachable when REST API returns 403.
+ */
+async function fetchGitHubLastCommitFromAtom(moduleUrl: string, client: HttpClient): Promise<string | null> {
+  const repoId = getRepositoryId(moduleUrl);
+  if (!repoId) {
+    return null;
+  }
+
+  try {
+    const atomUrl = `https://github.com/${repoId}/commits.atom`;
+    const result = await client.getText(atomUrl) as FetchTextResult;
+    if (!result.ok) {
+      return null;
+    }
+
+    const updatedMatch = result.data.match(/<updated>([^<]+)<\/updated>/u);
+    return updatedMatch?.[1] ?? null;
+  }
+  catch {
+    return null;
+  }
+}
+
 async function appendGitHubBatchResult({
   module,
   batchResults,
@@ -430,6 +455,25 @@ async function processModule(module: EnrichedModule, context: ProcessModuleConte
     };
   }
 
+  if (repoType === "github" && !process.env.GITHUB_TOKEN && recovery.error.message.includes("403")) {
+    const lastCommitFromAtom = await fetchGitHubLastCommitFromAtom(module.url, client);
+    if (lastCommitFromAtom) {
+      const atomRecovery: CachedRepositoryValue = {
+        lastCommit: lastCommitFromAtom,
+        isArchived: typeof module.isArchived === "boolean" ? module.isArchived : undefined,
+        hasGithubIssues: typeof module.hasGithubIssues === "boolean" ? module.hasGithubIssues : undefined
+      };
+
+      repositoryCache.set(repoId, atomRecovery);
+      logger.info(`Recovered ${module.name} lastCommit via GitHub Atom fallback`);
+
+      return {
+        ...module,
+        ...atomRecovery
+      };
+    }
+  }
+
   logger.warn(`Failed to fetch metadata for ${module.name}`, { url: module.url, error: recovery.error.message });
   circuitBreaker.recordError(recovery.error);
 

scripts/updateRepositoryApiData/__tests__/api.test.js

@@ -28,4 +28,15 @@ describe("updateRepositoryApiData/api", () => {
 
     assert.strictEqual(normalized.watchersCount, 7);
   });
+
+  it("does not infer watchersCount when subscribers_count is missing", () => {
+    const normalized = normalizeRepositoryData({
+      stargazers_count: 12,
+      has_issues: true,
+      archived: false,
+      defaultBranchRef: { target: { committedDate: "2026-01-01T00:00:00.000Z" } }
+    }, null, "github");
+
+    assert.strictEqual(typeof normalized.watchersCount, "undefined");
+  });
 });

scripts/updateRepositoryApiData/api.ts

@@ -37,6 +37,7 @@ interface RepositoryApiData {
   licenses?: Array<string | null>;
   mainbranch?: { name?: string | null } | null;
   pushedAt?: string | null;
+  pushed_at?: string | null;
   star_count?: number;
   stargazerCount?: number;
   stargazers_count?: number;
@@ -180,8 +181,13 @@ export function normalizeRepositoryData(data: RepositoryApiData, branchData: Rep
       stars = data.stargazers_count ?? data.stargazerCount ?? 0;
       license = data.license?.spdx_id ?? data.licenseInfo?.spdxId ?? null;
       hasGithubIssues = data.has_issues ?? data.hasIssuesEnabled ?? false;
-      lastCommit = branchData?.commit?.author?.date ?? data.defaultBranchRef?.target?.committedDate ?? data.pushedAt ?? null;
-      watchersCount = data.subscribers_count ?? 0;
+      lastCommit = branchData?.commit?.author?.date
+        ?? data.defaultBranchRef?.target?.committedDate
+        ?? data.pushed_at
+        ?? data.pushedAt
+        ?? null;
+      // Only trust an explicit API value. GraphQL batch payloads do not provide subscribers_count.
+      watchersCount = typeof data.subscribers_count === "number" ? data.subscribers_count : undefined;
       break;
     case "gitlab":
       stars = data.star_count ?? 0;