regex pattern for dependency check

[HeikoGr]

The dependency checker also includes false positives from comment lines:

https://github.com/MagicMirrorOrg/MagicMirror-3rd-Party-Modules/blob/4ee0d8b12a1c1dd04b7ed1e78635857872e05486/scripts/check-modules/dependency-usage.js#L37C1-L42C4

this should be better (proposal by github copilot - needs to be testet)

const DEPENDENCY_CAPTURE_PATTERNS = Object.freeze([
// CommonJS require - with const/let/var declaration
/^(?!\s*//)(?!\s*/*)(?!\s**)\s*(?:const|let|var)\s+.=\srequire\s*(\s*"'["']\s*)/gmu,

// ES6 from import - ONLY with import/export keyword
/^(?!\s*//)(?!\s*/*)(?!\s**)\s*(?:import|export)\s+.*\bfrom\s+"'["']/gmu,

// ES6 side-effect import
/^(?!\s*//)(?!\s*/*)(?!\s**)\s*import\s+"'["']/gmu,

// Dynamic import
/^(?!\s*//)(?!\s*/*)(?!\s**)\s*.import\s(\s*"'["']\s*)/gmu
]);

[KristjanESPERANTO]

Thanks for reporting this!

I'll have a look into it.

This is probably the specific case regarding MMM-Webuntis that led you to this conclusion, right?

Recommendation: The module imports { (used in cli/node_helper_wrapper.js), cookies (used in node_helper.js) but does not list them in package.json. Add these dependencies to package.json so they can be installed automatically. Declare every non built-in dependency you import so it can be installed automatically.

[HeikoGr]

absolutely!

the old variant matched:
// Match from defaults: from "{" to the closing "}" before getStyles()
and
cookieString: authResult.cookieString, // Changed from 'cookies' to 'cookieString'

so i changed the comment lines in my repo to shut up your check script :-)

I would understand if you want to keep the 'easier' regular expression.

[HeikoGr]

another solution could be to strip any comments beforehand ...

[KristjanESPERANTO]

Oh, I've solved that in the meantime. Thanks again for reporting it! 👍

I'm happy that you're using the list of issues 🙂