Add type check#142
Merged
KristjanESPERANTO merged 3 commits intoMagicMirrorOrg:mainfrom Feb 9, 2026
Merged
Conversation
JHWelch
commented
Feb 8, 2026
| "test": "node --run test:fixtures && node --run lint && node --run golden:check && node --run schemas:check && node --run test:unit && node --run test:types && node --run test:spelling", | ||
| "test:unit": "node --test scripts/**/__tests__/**/*.test.js", | ||
| "test:spelling": "cspell .", | ||
| "test:types": "tsc --noEmit", |
Contributor
Author
There was a problem hiding this comment.
tsc is the TypeScript Compiler. "noEmit" just does the type checks without actually "emitting" the JavaScript. "noEmit" is set to true in the tsconfig.json, so it will run in this mode by default but no reason not to be explicit here.
Collaborator
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a typescript type check based on discussions in #140 and the style of the Unit tests in #141