Skip to content

Commit 0bb9b5f

Browse files
authored
add test if install works for minimal node version (#4197)
and update minimal node version to `v22.22.2` Background: The latest release requires node `v22.22.2` because this version is required by a dev dependency, see https://forum.magicmirror.builders/post/131522 I added a new test for this (I didn't want to add another version to the test matrix ...) so that we see needed minimum node version upgrades earlier on develop (and not after release).
1 parent cdab7a7 commit 0bb9b5f

3 files changed

Lines changed: 21 additions & 2 deletions

File tree

.github/workflows/automated-tests.yaml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,25 @@ jobs:
3434
- name: "Run linter tests"
3535
run: |
3636
node --run test:lint
37+
min-node-version-install:
38+
runs-on: ubuntu-slim
39+
timeout-minutes: 15
40+
steps:
41+
- name: "Checkout code"
42+
uses: actions/checkout@v7
43+
- name: "Get minimum node version"
44+
id: get-version
45+
run: |
46+
NODE_VERSION="$(cat package.json | sed -rn 's|.*"node": ">=([0-9]+\.[0-9]+\.[0-9]+).*|\1|p')"
47+
echo "Minimal node version is $NODE_VERSION"
48+
echo "version=$NODE_VERSION" >> $GITHUB_OUTPUT
49+
- name: Set up Node.js
50+
uses: actions/setup-node@v6
51+
with:
52+
node-version: ${{ steps.get-version.outputs.version }}
53+
- name: "Install dependencies"
54+
run: |
55+
node --run install-mm:dev
3756
test:
3857
runs-on: ubuntu-24.04
3958
timeout-minutes: 30

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,6 @@
132132
"electron": "^43.0.0"
133133
},
134134
"engines": {
135-
"node": ">=22.21.1 <23 || >=24"
135+
"node": ">=22.22.2 <23 || >=24"
136136
}
137137
}

0 commit comments

Comments
 (0)