Skip to content

Commit 86888d9

Browse files
committed
allow environment variables in cors urls, optimize replace regex
1 parent 172ca18 commit 86888d9

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

js/node_helper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const NodeHelper = Class.extend({
9090
socket.onAny((notification, payload) => {
9191
if (config.hideConfigSecrets && payload && typeof payload === "object") {
9292
try {
93-
const payloadStr = JSON.stringify(payload).replaceAll(/\*\*(SECRET_.*)\*\*/g, (match, group) => {
93+
const payloadStr = JSON.stringify(payload).replaceAll(/\*\*(SECRET_[^*]+)\*\*/g, (match, group) => {
9494
return process.env[group];
9595
});
9696
this.socketNotificationReceived(notification, JSON.parse(payloadStr));

js/server_functions.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ async function cors (req, res) {
3535
return res.status(400).send(url);
3636
} else {
3737
url = match[1];
38+
if (config.hideConfigSecrets) {
39+
url = url.replaceAll(/\*\*(SECRET_[^*]+)\*\*/g, (match, group) => {
40+
return process.env[group];
41+
});
42+
}
3843

3944
const headersToSend = getHeadersToSend(req.url);
4045
const expectedReceivedHeaders = geExpectedReceivedHeaders(req.url);

0 commit comments

Comments
 (0)