refactor: unify favicon for index.html and Electron (#4006)

In #3407 we already talked about unifying them.

- Create SVG favicon (better then png)
- Replace base64 placeholder in index.html with SVG favicon
- Update electron.js to use SVG favicon instead of mm2.png
- Add favicon.svg to server static routes
- Remove mm2.png

Author: KristjanESPERANTO

favicon.svg

@@ -10,7 +10,7 @@
     <meta name="format-detection" content="telephone=no" />
     <meta name="mobile-web-app-capable" content="yes" />
 
-    <link rel="icon" href="data:;base64,iVBORw0KGgo=" />
+    <link rel="icon" href="favicon.svg" />
     <link rel="stylesheet" type="text/css" href="css/main.css" />
     <link rel="stylesheet" type="text/css" href="css/roboto.css" />
     <link rel="stylesheet" type="text/css" href="node_modules/animate.css/animate.min.css" />

index.html

@@ -48,7 +48,7 @@ function createWindow () {
 	let electronOptionsDefaults = {
 		width: electronSize.width,
 		height: electronSize.height,
-		icon: "mm2.png",
+		icon: "favicon.svg",
 		x: 0,
 		y: 0,
 		darkTheme: true,

js/electron.js

@@ -89,7 +89,7 @@ function Server (config) {
 			app.use(helmet(config.httpHeaders));
 			app.use("/js", express.static(__dirname));
 
-			let directories = ["/config", "/css", "/modules", "/node_modules/animate.css", "/node_modules/@fontsource", "/node_modules/@fortawesome", "/translations", "/tests/configs", "/tests/mocks"];
+			let directories = ["/config", "/css", "/favicon.svg", "/modules", "/node_modules/animate.css", "/node_modules/@fontsource", "/node_modules/@fortawesome", "/translations", "/tests/configs", "/tests/mocks"];
 			for (const [key, value] of Object.entries(vendor)) {
 				const dirArr = value.split("/");
 				if (dirArr[0] === "node_modules") directories.push(`/${dirArr[0]}/${dirArr[1]}`);