From 3cf58febf00b7e6fb9d4af11e491733e6d25c0dd Mon Sep 17 00:00:00 2001 From: bugsounet Date: Fri, 20 Jun 2025 11:51:15 +0200 Subject: [PATCH 1/2] review logger factory code part: use switch/case --- CHANGELOG.md | 1 + js/logger.js | 37 +++++++++++++++++++++++-------------- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dda71ff54a..1c49f51bdc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,6 +51,7 @@ planned for 2025-07-01 ### Updated - [core] Update dependencies including electron to v36 (#3774, #3788, #3811) +- [logger] Review factory code part: use `switch/case` instead of `if/else if` (#XXXX) ## [2.31.0] - 2025-04-01 diff --git a/js/logger.js b/js/logger.js index 1870987129..272c82c85a 100644 --- a/js/logger.js +++ b/js/logger.js @@ -11,26 +11,35 @@ label: (arg) => { const { method, defaultTokens } = arg; let label = defaultTokens.label(arg); - if (method === "error") { - label = styleText("red", label); - } else if (method === "warn") { - label = styleText("yellow", label); - } else if (method === "debug") { - label = styleText("bgBlue", label); - } else if (method === "info") { - label = styleText("blue", label); + switch (method) { + case "error": + label = styleText("red", label); + break; + case "warn": + label = styleText("yellow", label); + break; + case "debug": + label = styleText("bgBlue", label); + break; + case "info": + label = styleText("blue", label); + break; } return label; }, msg: (arg) => { const { method, defaultTokens } = arg; let msg = defaultTokens.msg(arg); - if (method === "error") { - msg = styleText("red", msg); - } else if (method === "warn") { - msg = styleText("yellow", msg); - } else if (method === "info") { - msg = styleText("blue", msg); + switch (method) { + case "error": + msg = styleText("red", msg); + break; + case "warn": + msg = styleText("yellow", msg); + break; + case "info": + msg = styleText("blue", msg); + break; } return msg; } From aa6199f2a7ec4da611d0881421657686ffa6f013 Mon Sep 17 00:00:00 2001 From: bugsounet Date: Fri, 20 Jun 2025 11:54:38 +0200 Subject: [PATCH 2/2] add PR number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1c49f51bdc..a1165846a9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,7 +51,7 @@ planned for 2025-07-01 ### Updated - [core] Update dependencies including electron to v36 (#3774, #3788, #3811) -- [logger] Review factory code part: use `switch/case` instead of `if/else if` (#XXXX) +- [logger] Review factory code part: use `switch/case` instead of `if/else if` (#3812) ## [2.31.0] - 2025-04-01