Skip to content

Show repeatingCountTitle only if yearDiff > 0#3948

Closed
jarnoml wants to merge 1 commit intoMagicMirrorOrg:masterfrom
jarnoml:patch-1
Closed

Show repeatingCountTitle only if yearDiff > 0#3948
jarnoml wants to merge 1 commit intoMagicMirrorOrg:masterfrom
jarnoml:patch-1

Conversation

@jarnoml
Copy link
Copy Markdown
Contributor

@jarnoml jarnoml commented Nov 5, 2025

Add condition to only append year difference if greater than 0.

Hello and thank you for wanting to contribute to the MagicMirror² project!

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.
  2. Include these infos in the description:
  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run node --run lint:prettier before submitting so that
    style issues are fixed.
  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

Add condition to only append year difference if greater than 0.
@rejas
Copy link
Copy Markdown
Collaborator

rejas commented Nov 5, 2025

hi and thanks for your contribution. two things:

  • please rebase your PR against the develop branch, we dont use master except for releases
  • could you add a before and after screenshot from your changes?

@jarnoml jarnoml closed this Nov 5, 2025
@jarnoml jarnoml deleted the patch-1 branch November 6, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants