Claude/setup magicmirror 01 krvfdo jmo qs nfd r6pa4 ndk#3966
Closed
rxf-sys wants to merge 4 commits intoMagicMirrorOrg:masterfrom
rxf-sys:claude/setup-magicmirror-01KrvfdoJmoQsNfdR6pa4Ndk
Closed
Claude/setup magicmirror 01 krvfdo jmo qs nfd r6pa4 ndk#3966rxf-sys wants to merge 4 commits intoMagicMirrorOrg:masterfrom rxf-sys:claude/setup-magicmirror-01KrvfdoJmoQsNfdR6pa4Ndk
rxf-sys wants to merge 4 commits intoMagicMirrorOrg:masterfrom
rxf-sys:claude/setup-magicmirror-01KrvfdoJmoQsNfdR6pa4Ndk
Conversation
Removed specific ignore rules for modules, CSS files, and config files.
CRITICAL SECURITY FIXES: - Move all sensitive data (API keys, passwords) from config.js to separate credentials.js - Add credentials.js to .gitignore to prevent accidental commits - Create credentials.example.js as template for new installations - Add comprehensive config/README.md with security documentation BUG FIXES: - Fix typo in OpenWeather module configuration (remove "NN" prefix) - Disable debug mode in NewsAPI module IMPROVEMENTS: - Fix CSS variable references (--text-xs -> --font-size-xsmall, --text-sm -> --font-size-small) - Improve code organization and documentation This commit removes all sensitive credentials from version control while maintaining functionality through a secure credentials import system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thank you for wanting to contribute to the MagicMirror² project!
Please make sure that you have followed these 4 rules before submitting your Pull Request:
Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of
developbefore creating apull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks again and have a nice day!