feat: add Sense HAT integration module#3983
Closed
GEmanuel2558 wants to merge 1 commit intoMagicMirrorOrg:developfrom
Closed
feat: add Sense HAT integration module#3983GEmanuel2558 wants to merge 1 commit intoMagicMirrorOrg:developfrom
GEmanuel2558 wants to merge 1 commit intoMagicMirrorOrg:developfrom
Conversation
Collaborator
|
This should be a third party module, not part of the base |
Collaborator
|
See the documentation Also see my PythonPrint module for structure to call python script Your module Is really just a repackaging |
Collaborator
I agree. |
653f6ec to
9879e38
Compare
Collaborator
|
You based this on master branch please acknowledge that this PR will be rejected and you should repackage your module as a standalone. |
9879e38 to
a1657d3
Compare
Author
|
Thank you for the code review, I will make a new MR, and will make sure to follow your advice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
sensehatmodule for MagicMirror² that integrates with the Raspberry Pi Sense HAT. The module reads environmental and orientation data from the Sense HAT and can optionally control the 8×8 RGB LED matrix for simple status feedback.What’s included
New frontend module:
modules/default/sensehat/sensehat.jsNew Node helper:
modules/default/sensehat/node_helper.jsSENSEHAT_DATAnotifications to the frontend.SENSEHAT_LED_COMMANDmessages to control the LED matrix (e.g. status colors).Python helper script:
modules/default/sensehat/python/reader.pysense_hatPython library.Documentation & config:
modules/default/sensehat/README.mdwith usage notes and setup steps.config/config.js.sampleupdated with an examplesensehatmodule configuration.Configuration
Example config: