[demo] feat: add demo#3993
Closed
KristjanESPERANTO wants to merge 1 commit intoMagicMirrorOrg:developfrom
Closed
Conversation
Collaborator
|
I'm not sure but are these the right fonts on the demo page? |
Collaborator
|
Another demo approach could be to run a normal server instance on our server and publish it e.g. under |
Collaborator
|
I think this is the better way. Keep it up to date as we release |
Collaborator
|
because we have already everything I added a few lines in the server setup, result see https://demo.magicmirror.builders/ |
Collaborator
Author
Oh, I have to fix this, but let's see if we decide for my approach or not 🙂 |
Collaborator
Author
|
Replaced by another approach (#3995) 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started as an experiment to see if it's possible to run MagicMirror² for showcasing directly in the browser without a server. The demo uses the real MagicMirror core files and default modules, only mocking server components (API calls, Socket.IO, node helpers).
Live preview: https://kristjanesperanto.github.io/MagicMirror/
After merge and next release, the demo would be available at: https://magicmirrororg.github.io/MagicMirror/
Even if the code doesn't add too many lines to the repository, it increases our maintenance effort. So the question is whether we want that. I'm not so sure myself. For me, my experiment was successful and actually complete. I think a live demo is kind of cool, and if the effort is too great for us, we could easily remove the demo at some point, since it's not interwoven with the rest.
But it's no problem if we drop it 🙂