Skip to content

Fix "implicit optional", e.g. arg: int = None#1239

Merged
elprans merged 2 commits intoMagicStack:masterfrom
andrew222651:fix-implicit-optional
Mar 16, 2025
Merged

Fix "implicit optional", e.g. arg: int = None#1239
elprans merged 2 commits intoMagicStack:masterfrom
andrew222651:fix-implicit-optional

Conversation

@andrew222651
Copy link
Copy Markdown
Contributor

The latest version of Pyright makes calling a function with an "implicit optional" a type error. An "implicit optional" is like the following code, where a parameter is annotated with a type that doesn't include None but the default value is None:

def foo(arg: int = None):
    pass

More info here: https://docs.astral.sh/ruff/rules/implicit-optional/

This PR adds typing.Optional where necessary.

@elprans elprans merged commit 07e163f into MagicStack:master Mar 16, 2025
1 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants