Fix subprocess_shell code (Windows Side) (#4)

* add another branch to test on my end

* force trigger workflow

* reformat test_context with black

* reformat all tests to obey flake8

* fix flake8 errors

* add dns related things from winloop

* try something that isn't invalid on 3.8

* reformat with black using valid 3.8 syntax and the 79 character limit

* update setup.py

* fix more formatting problems with test_process

* uncomment trest_process_streams_pass_fds on windows

* slience all other known to fail tests with windows

* fix if statement for dns.pyx

* silencing reamining failures

* remove whitespace

* update tests

* update tests

* skip signal test on apple for now

* remove whitespace

* reformat with black once more

* mark todo for issue 126 (winloop) related

* skip test_call_later_2 on windows normal asyncio in 3.11 due to rounding bug

* reformat test_base.py

* uvloop still has the same problem on windows 3.11

* siganls fork test broken

* better skipping system for test_base.py

* add extra removal to makefile

* nope, 3.8+ on windows has the same problem wiht test_call_later_2

* add __Pyx_MonitoringEventTypes_CyGen_count as a macro incase accidently exposed in windows debug mode

* skip create over ssl when in win32 3.14t it's currently a todo bugfix.

* skip test_getaddrinfo_4 on mac, it can randomly freeze at different times.

* fix subprocess shell code for window's end

* update stdlib with os.path.join to help it out

* add isabs to subprocess_shell

* make outer modules used into constant values

* forgot about errors.pyx let me fix that up real quickly

Author: Vizonex

uvloop/dns.pyx

@@ -352,12 +352,12 @@ cdef class AddrInfoRequest(UVRequest):
 
         if host is None:
             chost = NULL
-        elif host == b'' and sys.platform == 'darwin':
+        elif host == b'' and sys_platform == 'darwin':
             # It seems `getaddrinfo("", ...)` on macOS is equivalent to
             # `getaddrinfo("localhost", ...)`. This is inconsistent with
             # libuv 1.48 which treats empty nodename as EINVAL.
             chost = <char*>'localhost'
-        elif host == b'' and sys.platform == "win32":
+        elif host == b'' and sys_platform == "win32":
             # On Windows, `getaddrinfo("", ...)` is *almost* equivalent to
             # `getaddrinfo("..localmachine", ...)`. This is inconsistent with
             # libuv 1.48 which treats empty nodename as EINVAL.
@@ -398,7 +398,7 @@ cdef class AddrInfoRequest(UVRequest):
                     # EAI_NONAME [ErrNo 10001] "No such host is known. ".
                     # We replace the message with "getaddrinfo failed".
                     # See also errors.pyx.
-                    if sys.platform == 'win32':
+                    if sys_platform == 'win32':
                         msg = 'getaddrinfo failed'
                     else:
                         msg = system.gai_strerror(socket_EAI_NONAME).decode('utf-8')

uvloop/errors.pyx

@@ -131,7 +131,7 @@ cdef convert_error(int uverr):
         # EAI_FAMILY [ErrNo 10047] "An address incompatible with the requested protocol was used. "
         # EAI_NONAME [ErrNo 10001] "No such host is known. "
         # We replace these messages with "getaddrinfo failed"
-        if sys.platform == "win32":
+        if sys_platform == "win32":
             if sock_err in (socket_EAI_FAMILY, socket_EAI_NONAME):
                 msg = 'getaddrinfo failed'
         return socket_gaierror(sock_err, msg) 

uvloop/includes/stdlib.pxi

@@ -100,6 +100,8 @@ cdef int socket_EAI_SOCKTYPE   = getattr(socket, 'EAI_SOCKTYPE', -1)
 
 
 cdef str os_name = os.name
+cdef os_path_isabs = os.path.isabs
+cdef os_path_join = os.path.join
 cdef os_environ = os.environ
 cdef os_dup = os.dup
 cdef os_set_inheritable = os.set_inheritable

uvloop/loop.pyx

@@ -2824,34 +2824,25 @@ cdef class Loop:
         if not shell:
             raise ValueError("shell must be True")
 
-        
         if not system.PLATFORM_IS_WINDOWS:
             args = [cmd]
             if shell:
                 args = [b'/bin/sh', b'-c'] + args
         else:
-            if not shell:
-                args = [cmd]
-            else:
-                # XXX: os is somehow nonexistant. 
-                # TODO: Fix OS Import on windows. 
-                import os
-                # CHANGED WINDOWS Shell see : https://github.com/libuv/libuv/pull/2627 for more details...
-
-                # Winloop comment: args[0].split(' ') instead of args to pass some tests in test_process
-
-                # See subprocess.py for the mirror of this code.
-                comspec = os.environ.get("ComSpec")
-                if comspec:
-                    system_root = os.environ.get("SystemRoot", '')
-                    comspec = os.path.join(system_root, 'System32', 'cmd.exe')
-                    if not os.path.isabs(comspec):
-                        raise FileNotFoundError('shell not found: neither %ComSpec% nor %SystemRoot% is set')
-
-                args = [comspec]
-                args.append('/c')
-                # TODO: (Vizonex) We probably need a new solution besides using a shlex parser setup.
-                args.append(cmd)
+            # SEE: https://github.com/libuv/libuv/pull/2627
+
+            # See subprocess.py for the mirror of this code.
+            comspec = os_environ.get("ComSpec")
+            if not comspec:
+                system_root = os_environ.get("SystemRoot", '')
+                comspec = os_path_join(system_root, 'System32', 'cmd.exe')
+                if not os_path_isabs(comspec):
+                    raise FileNotFoundError('shell not found: neither %ComSpec% nor %SystemRoot% is set')
+            
+            args = [comspec]
+            args.append('/c')
+            args.append(cmd)
+
         return await self.__subprocess_run(protocol_factory, args, shell=True,
                                            **kwargs)