Skip to content

Commit ff6b2ec

Browse files
author
Ethan Kenny
committed
Follow AdX style for extensions, cleanup
1 parent 685803e commit ff6b2ec

1 file changed

Lines changed: 65 additions & 66 deletions

File tree

com/magnite/openrtb/openrtb-xapi.proto

Lines changed: 65 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ message BidRequestExt {
3333
}
3434

3535
optional Rp rp = 1;
36+
}
3637

37-
extend com.iabtechlab.openrtb.v2.BidRequest {
38-
optional BidRequestExt ext = 5010;
39-
}
38+
extend com.iabtechlab.openrtb.v2.BidRequest {
39+
optional BidRequestExt bid_request = 5010;
4040
}
4141

4242
// Imp
@@ -74,11 +74,11 @@ message ImpExt {
7474
optional Rp rp = 1;
7575
optional Window window = 2;
7676
repeated string viewabilityvendors = 3;
77+
}
7778

78-
extend com.iabtechlab.openrtb.v2.BidRequest.Imp {
79-
optional ImpExt ext = 5010;
80-
}
81-
};
79+
extend com.iabtechlab.openrtb.v2.BidRequest.Imp {
80+
optional ImpExt imp = 5010;
81+
}
8282

8383
// Video
8484
message VideoExt {
@@ -97,11 +97,11 @@ message VideoExt {
9797
optional bool skip = 4;
9898
optional int32 skipdelay = 5;
9999
optional int32 placement = 6; // ortb enum VideoPlacementType
100+
}
100101

101-
extend com.iabtechlab.openrtb.v2.BidRequest.Imp.Video {
102-
optional VideoExt ext = 5010;
103-
}
104-
};
102+
extend com.iabtechlab.openrtb.v2.BidRequest.Imp.Video {
103+
optional VideoExt video = 5010;
104+
}
105105

106106
// Banner
107107
message BannerExt {
@@ -114,11 +114,11 @@ message BannerExt {
114114
}
115115

116116
optional Rp rp = 1;
117+
}
117118

118-
extend com.iabtechlab.openrtb.v2.BidRequest.Imp.Banner {
119-
optional BannerExt ext = 5010;
120-
}
121-
};
119+
extend com.iabtechlab.openrtb.v2.BidRequest.Imp.Banner {
120+
optional BannerExt banner = 5010;
121+
}
122122

123123
message Transparency {
124124
optional int32 blind = 1;
@@ -141,11 +141,11 @@ message AppExt {
141141
}
142142

143143
optional Rp rp = 1;
144+
}
144145

145-
extend com.iabtechlab.openrtb.v2.BidRequest.App {
146-
optional AppExt ext = 5010;
147-
}
148-
};
146+
extend com.iabtechlab.openrtb.v2.BidRequest.App {
147+
optional AppExt app = 5010;
148+
}
149149

150150
// Site
151151
message SiteExt {
@@ -158,11 +158,11 @@ message SiteExt {
158158

159159
optional Rp rp = 1;
160160
optional Window window = 2;
161+
}
161162

162-
extend com.iabtechlab.openrtb.v2.BidRequest.Site {
163-
optional SiteExt ext = 5010;
164-
}
165-
};
163+
extend com.iabtechlab.openrtb.v2.BidRequest.Site {
164+
optional SiteExt site = 5010;
165+
}
166166

167167
// Publisher
168168
message PublisherExt {
@@ -171,11 +171,11 @@ message PublisherExt {
171171
}
172172

173173
optional Rp rp = 1;
174+
}
174175

175-
extend com.iabtechlab.openrtb.v2.BidRequest.Publisher {
176-
optional PublisherExt ext = 5010;
177-
}
178-
};
176+
extend com.iabtechlab.openrtb.v2.BidRequest.Publisher {
177+
optional PublisherExt publisher = 5010;
178+
}
179179

180180
// Device
181181
message DeviceExt {
@@ -192,11 +192,11 @@ message DeviceExt {
192192
optional Rp rp = 1;
193193
optional bool ipmask = 2;
194194
optional Dooh dooh = 3;
195+
}
195196

196-
extend com.iabtechlab.openrtb.v2.BidRequest.Device {
197-
optional DeviceExt ext = 5010;
198-
}
199-
};
197+
extend com.iabtechlab.openrtb.v2.BidRequest.Device {
198+
optional DeviceExt device = 5010;
199+
}
200200

201201
// Geo
202202
message GeoExt {
@@ -205,11 +205,11 @@ message GeoExt {
205205
}
206206

207207
optional Rp rp = 1;
208+
}
208209

209-
extend com.iabtechlab.openrtb.v2.BidRequest.Geo {
210-
optional GeoExt ext = 5010;
211-
}
212-
};
210+
extend com.iabtechlab.openrtb.v2.BidRequest.Geo {
211+
optional GeoExt geo = 5010;
212+
}
213213

214214
// User
215215
message UserExt {
@@ -227,30 +227,30 @@ message UserExt {
227227
optional string us_privacy = 2;
228228
optional Rp rp = 3;
229229
optional string liveramp_idl = 4;
230+
}
230231

231-
extend com.iabtechlab.openrtb.v2.BidRequest.User {
232-
optional UserExt ext = 5010;
233-
}
234-
};
232+
extend com.iabtechlab.openrtb.v2.BidRequest.User {
233+
optional UserExt user = 5010;
234+
}
235235

236236
// Regs
237237
message RegsExt {
238238
optional bool s22580 = 1;
239239
optional string us_privacy = 2;
240+
}
240241

241-
extend com.iabtechlab.openrtb.v2.BidRequest.Regs {
242-
optional RegsExt ext = 5010;
243-
}
244-
};
242+
extend com.iabtechlab.openrtb.v2.BidRequest.Regs {
243+
optional RegsExt regs = 5010;
244+
}
245245

246246
// Source
247247
message SourceExt {
248248
optional bool ssreq = 1;
249+
}
249250

250-
extend com.iabtechlab.openrtb.v2.BidRequest.Source {
251-
optional SourceExt ext = 5010;
252-
}
253-
};
251+
extend com.iabtechlab.openrtb.v2.BidRequest.Source {
252+
optional SourceExt source = 5010;
253+
}
254254

255255
// Native
256256
message NativeExt {
@@ -259,20 +259,20 @@ message NativeExt {
259259
}
260260

261261
optional Rp rp = 1;
262+
}
262263

263-
extend com.iabtechlab.openrtb.v2.BidRequest.Imp.Native {
264-
optional NativeExt ext = 5010;
265-
}
266-
};
264+
extend com.iabtechlab.openrtb.v2.BidRequest.Imp.Native {
265+
optional NativeExt native = 5010;
266+
}
267267

268268
// NativeRequest
269269
message NativeRequestExt {
270270
optional bool privacy = 1;
271+
}
271272

272-
extend com.iabtechlab.openrtb.v2.NativeRequest {
273-
optional NativeRequestExt ext = 5010;
274-
}
275-
};
273+
extend com.iabtechlab.openrtb.v2.NativeRequest {
274+
optional NativeRequestExt native_request = 5010;
275+
}
276276

277277

278278
// ===== Response =====
@@ -292,11 +292,11 @@ message BidResponseExt {
292292
}
293293

294294
optional Rp rp = 1;
295+
}
295296

296-
extend com.iabtechlab.openrtb.v2.BidResponse {
297-
optional BidResponseExt ext = 5011;
298-
}
299-
};
297+
extend com.iabtechlab.openrtb.v2.BidResponse {
298+
optional BidResponseExt bid_response = 5011;
299+
}
300300

301301
// SeatBidExt
302302
message SeatBidExt {
@@ -305,10 +305,10 @@ message SeatBidExt {
305305
}
306306

307307
optional Rp rp = 1;
308+
}
308309

309-
extend com.iabtechlab.openrtb.v2.BidResponse.SeatBid {
310-
optional SeatBidExt ext = 5011;
311-
}
310+
extend com.iabtechlab.openrtb.v2.BidResponse.SeatBid {
311+
optional SeatBidExt seatbid = 5011;
312312
}
313313

314314
// BidExt
@@ -332,9 +332,8 @@ message BidExt {
332332
}
333333

334334
optional Rp rp = 1;
335-
336-
extend com.iabtechlab.openrtb.v2.BidResponse.SeatBid.Bid {
337-
optional BidExt ext = 5011;
338-
}
339335
}
340336

337+
extend com.iabtechlab.openrtb.v2.BidResponse.SeatBid.Bid {
338+
optional BidExt bid = 5011;
339+
}

0 commit comments

Comments
 (0)