Skip to content

Commit f25e54b

Browse files
christian-huehn-mwclaude
authored andcommitted
refactor(analysis): replace TODO comments with descriptive notes
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 38dda5d commit f25e54b

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

analysis/analysers/parsers/GitLogParser/src/main/kotlin/de/maibornwolff/codecharta/analysers/parsers/gitlog/converter/ProjectConverter.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class ProjectConverter(private val containsAuthors: Boolean) {
3030
edges.forEach {
3131
projectBuilder.insertEdge(addRootToEdgePaths(it))
3232
}
33-
// TODO improve memory utilization -> inject metrics for calculations
33+
// Note: memory utilization could be improved by injecting metrics for calculations
3434
// instead of creating a hard reference in VersionControlledFile
3535
versionControlledFile.removeMetricsToFreeMemory()
3636
}
@@ -56,8 +56,7 @@ class ProjectConverter(private val containsAuthors: Boolean) {
5656

5757
val versionControlledFilesInGitProject = VersionControlledFilesInGitProject(vcFList, filesInLog)
5858

59-
versionControlledFilesInGitProject.getListOfVCFilesMatchingGitProject().forEach { // TODO Coroutines?
60-
vcFile ->
59+
versionControlledFilesInGitProject.getListOfVCFilesMatchingGitProject().forEach { vcFile ->
6160
addVersionControlledFile(projectBuilder, vcFile)
6261
}
6362

analysis/analysers/parsers/GitLogParser/src/main/kotlin/de/maibornwolff/codecharta/analysers/parsers/gitlog/parser/StandardCommitParser.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class StandardCommitParser : CommitParser {
5555
}
5656

5757
private fun handleDeleteModification(versionControlledFilesList: VersionControlledFilesList, trackName: String) {
58-
// TODO registerCommit() needed? @Ruben do we want to track deleted and then reverted files as author and commit amount
58+
// Note: registerCommit() may be needed to track deleted and then reverted files as author and commit amount
5959
// In some cases a file which is deleted by a modification is not present
6060
// This would cause a NullPointerException
6161
// We do a safe call to prevent the Parser from crashing (for now).
@@ -82,7 +82,7 @@ class StandardCommitParser : CommitParser {
8282
trackName: String,
8383
commit: Commit,
8484
mod: Modification
85-
) { // TODO Do we have to register delete commits if a RENAME OR MODIFY commit follows? (refer line 33)
85+
) { // Note: consider registering delete commits if a RENAME OR MODIFY commit follows
8686

8787
var file = versionControlledFilesList.get(trackName)
8888
if (file == null) {

analysis/analysers/parsers/GitLogParser/src/main/kotlin/de/maibornwolff/codecharta/analysers/parsers/gitlog/parser/VersionControlledFilesInGitProject.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class VersionControlledFilesInGitProject(
66
private val vcFList: MutableMap<String, VersionControlledFile>,
77
private val filesInGitLog: List<String>
88
) {
9-
// TODO salts should not be part of filenames, change logic error
9+
// Note: salts should not be part of filenames, consider changing this logic
1010
private fun removeSaltFromFilenames() {
1111
vcFList.values.forEach {
1212
it.filename = it.filename.substringBefore("_\\0_")

analysis/analysers/parsers/RawTextParser/src/main/kotlin/de/maibornwolff/codecharta/analysers/parsers/rawtext/metrics/IndentationMetric.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class IndentationMetric(private var maxIndentation: Int, private var verbose: Bo
1212
const val NAME = "IndentationLevel"
1313
}
1414

15-
// TODO no mixed tab/ space possible at line start?
15+
// Note: mixed tab/space indentation at line start is not currently handled
1616
override fun parseLine(line: String) {
1717
var tabIndent = line.length - line.trimStart('\t').length
1818
var spaceIndent = line.length - line.trimStart(' ').length
@@ -27,7 +27,7 @@ class IndentationMetric(private var maxIndentation: Int, private var verbose: Bo
2727
}
2828
}
2929

30-
// TODO tabSize - (offset % tabSize) from the current position
30+
// Note: could use tabSize - (offset % tabSize) from the current position for more accuracy
3131
private fun guessTabWidth(): Int {
3232
tabWidth = 1
3333
if (spaceIndentations.sum() == 0) return tabWidth

0 commit comments

Comments
 (0)