[flutter_local_notifications] add support for notifications on android auto - #2748
[flutter_local_notifications] add support for notifications on android auto#2748derrik-fleming wants to merge 3 commits into
Conversation
derrik-fleming
changed the title
| * plugin | ||
| * for proper Android Auto support. | ||
| * | ||
| * Implementing this interface allows your MainActivity to provide the |
There was a problem hiding this comment.
Based on the API docs, is this implying developers will need to update native code before they can make use of the changes in this PR?
If so, what sticks out to me is the following
- readme should be updated to add instructions on what changes are required on the native side
- if possible, update example app with the changes so that there is one button for the scenario where it shows a notification on Android Auto. I haven't worked with Android Auto before but once PR is ready, I assume the emulator can be used to see how the example runs there
There was a problem hiding this comment.
Based on the API docs, is this implying developers will need to update native code before they can make use of the changes in this PR?
Yes, but the requirement here is fairly minimal in that, if a developer wants notifications on Android Auto via flutter_local_notifications they must provide a reference to their implementation of CarAppService by implementing the CarAppServiceClassConsumer interface on the Activity.
To be clear, I'm open to opinions here, but what I was attempting to do is create a bridge at the application level that flutter_local_notifications could leverage to retrieve the necessaries from a plugin providing Android Auto features (or wherever the CarAppService implementation is defined).
readme should be updated to add instructions on what changes are required on the native side
I definitely can do that.
if possible, update example app with the changes so that there is one button for the scenario where it shows a notification on Android Auto. I haven't worked with Android Auto before but once PR is ready, I assume the emulator can be used to see how the example runs there
I'm not sure this can be easily accomplished but I can look into it. If anything, I could add some commented out snippets in there that might be helpful.
There was a problem hiding this comment.
I'm feeling like the docs I added to the README.md might be enough to cover your related concerns with respect to the example app, but let me know if not.
There was a problem hiding this comment.
It partially does. I should have clarified the main reason on having updates in the example app is so that the app contains as much code that is ready to run to demonstrate all available features. It also helps that when a bug is reported, developers can use the app to see if they can reproduce the scenario. If the example app is missing the scenario, developers can fork it and add the scenario they run into.
With all that said, if possible and assuming the entire app can run on an Android auto device, can you see if it can be updated? Happy to help out where needed and if it's not possible for whatever reason then do let me know
|
I will take a look at this more properly once the iOS one is merged in but have left comments from what I've seen so far. In case you haven't seen it yet, it says your branch has conflicts right now |
f642993 to
3e4dcc5
Compare
MaikuB
left a comment
MaikuB
left a comment
There was a problem hiding this comment.
@derrik-fleming I tried to see if I could merge this with the view that example app could be updated later. However, I noticed pipeline checks failed. I've addressed the linter issue that if you updated your fork and branch that it'll pick it up. Are you able to look into the failing tests though?
2 participants
Closes #2747