Add touch event listeners for mobile movement tracking in speed modifier component#18
Merged
MakingSpiderSense merged 1 commit intoJun 17, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the movement-speed-modifier A-Frame component to recognize mobile touch activity as an additional “moving forward” signal, primarily to keep speed-line visibility in sync with touch-based movement.
Changes:
- Added
touchCountstate and touch start/end handlers to track the number of active touches. - Added lifecycle-managed
touchstart/touchend/touchcancellisteners. - Updated
isMovingForward()to include single-touch as a forward-movement indicator.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+158
to
+162
| addTouchListeners: function () { | ||
| window.addEventListener("touchstart", this.onTouchStart); | ||
| window.addEventListener("touchend", this.onTouchEnd); | ||
| window.addEventListener("touchcancel", this.onTouchEnd); | ||
| }, |
Owner
Author
There was a problem hiding this comment.
Tested and there were no warnings. Scroll performance is not applicable for A-Frame scenes.
Comment on lines
+169
to
+173
| removeTouchListeners: function () { | ||
| window.removeEventListener("touchstart", this.onTouchStart); | ||
| window.removeEventListener("touchend", this.onTouchEnd); | ||
| window.removeEventListener("touchcancel", this.onTouchEnd); | ||
| }, |
Owner
Author
There was a problem hiding this comment.
Not applicable.
Comment on lines
+341
to
+342
| const touchMovingForward = this.touchCount === 1; // 1 finger = forward, 2 = backward | ||
| return keyboardMovingForward || joystickMovingForward || armSwingMovingForward || touchMovingForward; |
Owner
Author
There was a problem hiding this comment.
It doesn't need to check this.data.enabled since speed line visibility is blocked at the tick() level.
Comment on lines
+270
to
+273
| onTouchStart: function (event) { | ||
| this.touchCount = event.touches.length; | ||
| this.syncSpeedLinesVisibility(); | ||
| }, |
| const joystickMovingForward = this.isJoystickForward(); | ||
| const armSwingMovingForward = armSwingMovement && armSwingMovement.moving && !armSwingMovement.reverseHeld; | ||
| return keyboardMovingForward || joystickMovingForward || armSwingMovingForward; | ||
| const touchMovingForward = this.touchCount === 1; // 1 finger = forward, 2 = backward |
Owner
Author
There was a problem hiding this comment.
It's the touch-controls component that treats it this way.
MakingSpiderSense
deleted the
bugfix/movement-speed-modifier/118-show-speed-lines-on-mobile
branch
MakingSpiderSense
restored the
bugfix/movement-speed-modifier/118-show-speed-lines-on-mobile
branch
This was referenced Jun 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves support for mobile touch input to the
movement-speed-modifiercomponent. The main changes include tracking touch events, updating movement logic to recognize touch-based movement, and ensuring that speed lines show up when moving forward on mobile.Mobile touch input support:
touchCountproperty and methods (onTouchStart,onTouchEnd) to track the number of fingers on the screen, and update movement state accordingly. [1] [2]addTouchListenersandremoveTouchListenersmethods to manage touch event listeners during component lifecycle. [1] [2]Movement logic updates:
isMovingForwardmethod to support forward movement when one finger is on the screen (two fingers moves the player backwards, so that would register asfalse), allowing for mobile-friendly movement controls.Trello: https://trello.com/c/GmhnPkKL