Automatically accept whatever licenses there are#8
Automatically accept whatever licenses there are#8hoff2-ACN wants to merge 3 commits intoMalinskiy:masterfrom
Conversation
Malinskiy
left a comment
Malinskiy
left a comment
There was a problem hiding this comment.
Please don't remove the dead code. It's a shared code between actions in this repo and I don't see a better way to share it at the moment. I'd be happy if you showed a better way to share this as a module between all the actions though.
| await writeLicenseFile(`${this.androidHome()}/licenses/mips-android-sysimage-license`, "e9acab5b5fbb560a72cfaecce8946896ff6aab9d\n") | ||
| await writeLicenseFile(`${this.androidHome()}/licenses/google-gdk-license`, "33b6a2b64607f11b759f320ef9dff4ae5c47d97a\n") | ||
| await writeLicenseFile(`${this.androidHome()}/licenses/android-googletv-license`, "601085b94cd77f0b54ff86406957099ebe79c4d6\n") | ||
| await execWithResult(`bash -c \\\"yes | ${this.androidHome()}/tools/bin/sdkmanager --licenses"`); |
There was a problem hiding this comment.
This was already broken before so unfortunately we need to specify licenses explicitly
There was a problem hiding this comment.
Has been working for me, wonder what the trouble was
There was a problem hiding this comment.
The "dead" code removed was only the writeLicenseFile function which I was able to determine was only being used here
There was a problem hiding this comment.
If you look on the diff for this PR, you'll see lot's of other code removed
2 participants
use the
sdkmanagercli to automatically accept licenses to try to fix #5