Fix display_blank_page not showing only the blank page#200
Open
MallocArray wants to merge 1 commit into
Open
Conversation
Previously, switching to blank triggered on_page_change -> blank, which always jumped to show_next whenever any non-blank page was enabled. Now that jump is gated by switch.is_off: display_blank_page, so enabling display_blank_page keeps the screen blank as intended.
Owner
Author
|
@librick With this change, you can now only turn on "Display Blank Page" and it immediately blanks the screen. See any issues? Would like to merge in the next 24 hours if you have time to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, switching to blank triggered on_page_change -> blank, which always jumped to show_next whenever any non-blank page was enabled. Now that jump is gated by switch.is_off: display_blank_page, so enabling display_blank_page keeps the screen blank as intended.