Skip to content

Add Paths and Parameters to OpenAPI spec generation#1319

Open
agrare wants to merge 5 commits into
ManageIQ:masterfrom
agrare:build_openapi_spec
Open

Add Paths and Parameters to OpenAPI spec generation#1319
agrare wants to merge 5 commits into
ManageIQ:masterfrom
agrare:build_openapi_spec

Conversation

@agrare
Copy link
Copy Markdown
Member

@agrare agrare commented Apr 29, 2026

No description provided.

@agrare agrare requested a review from bdunne as a code owner April 29, 2026 16:26
@agrare agrare force-pushed the build_openapi_spec branch from 55bf7ae to 657a7c6 Compare April 29, 2026 16:27
Comment thread .github/workflows/openapi-generate.yml Outdated
Comment thread .github/workflows/openapi-generate.yml
Comment thread .github/workflows/openapi-generate.yml Outdated
Comment thread .github/workflows/openapi-generate.yml Outdated
Comment thread .github/workflows/openapi-generate.yml Outdated
Comment thread .github/workflows/openapi-generate.yml
- name: Create Pull Request
uses: peter-evans/create-pull-request@v8
with:
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to self that I need to associate this token with this repo after merge.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second reminder, I also need to fork this repo on the bot account.

Comment thread .github/workflows/openapi-generate.yml Outdated
- [ ] Validate security schemes are properly defined

---
*This PR was automatically generated by GitHub Actions*
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is kind of cool - wondering if we should add that to the other ones, perhaps along with a reference back to the action that generated it. Maybe the "generated by" here can be the link.

Comment thread .github/workflows/openapi-generate.yml Outdated
Comment thread lib/manageiq/api/open_api/generator.rb Outdated
Comment thread lib/manageiq/api/open_api/operation_builder.rb Outdated
Comment thread lib/manageiq/api/open_api/schema_builder.rb Outdated
@agrare agrare force-pushed the build_openapi_spec branch from 657a7c6 to a7d02c6 Compare April 29, 2026 16:54
Comment thread lib/manageiq/api/open_api/operation_builder.rb Outdated
Comment thread lib/manageiq/api/open_api/operation_builder.rb Outdated
@agrare agrare force-pushed the build_openapi_spec branch 3 times, most recently from 71f2f37 to b345384 Compare April 29, 2026 17:24
@agrare agrare force-pushed the build_openapi_spec branch from b345384 to 1341ad9 Compare April 29, 2026 17:28
@agrare agrare force-pushed the build_openapi_spec branch from b8f4d24 to 5d93e3f Compare April 29, 2026 19:48
@Fryguy
Copy link
Copy Markdown
Member

Fryguy commented Apr 29, 2026

Nice it dropped from +120k to +90k - good savings

@miq-bot
Copy link
Copy Markdown
Member

miq-bot commented May 19, 2026

Checked commits agrare/manageiq-api@b9c4b43~...8385f1d with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.73.0, and yamllint 1.37.1
6 files checked, 1 offense detected

.github/workflows/openapi-generate.yml

  • ⚠️ - Line 69, Col 121 - 139 > 120 characters) (line-length - line too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants