You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 12, 2023. It is now read-only.
I noticed that both GraphQLDatabaseLoader and GraphQLQueryBuilder use generic extending typeof BaseEntity which is incorrect in some cases because Entity might not be extended from BaseEntity. It enables some difficulties to implement correct typing in real use. It seems everything works great if entity isn't extended from BaseEntity, so I think it's redundant typing. Please, fix it.
I noticed that both
GraphQLDatabaseLoaderandGraphQLQueryBuilderuse generic extendingtypeof BaseEntitywhich is incorrect in some cases becauseEntitymight not be extended fromBaseEntity. It enables some difficulties to implement correct typing in real use. It seems everything works great if entity isn't extended fromBaseEntity, so I think it's redundant typing. Please, fix it.