Merge pull request #33 from ManiVaultStudio/feature/fix-32

jeggermont · web-flow · commit 75ecf1c0b59e · 2025-09-05T13:06:55.000+02:00
Fixes #32 Loading properties from "var" can cause crashes when using dimension selection
diff --git a/src/HDF5_AD_Loader.cpp b/src/HDF5_AD_Loader.cpp
@@ -227,7 +227,7 @@ static void LoadProperties(H5::Group &group, H5AD::LoaderInfo &datasetInfo)
 									 label += " (label)";
 									 if (labels.size())
 									 {
-										 filterValues(labels, datasetInfo._selectedDimensionsLUT);
+										 // it shouldn't be needed to filter the labels since they are based on the values which where already filtered.
 										 propertyMap[label] = labels;
 									 }
 								 }

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ static void LoadProperties(H5::Group &group, H5AD::LoaderInfo &datasetInfo)`
`227`	`227`	`label += " (label)";`
`228`	`228`	`if (labels.size())`
`229`	`229`	`{`
`230`		`- filterValues(labels, datasetInfo._selectedDimensionsLUT);`
	`230`	`+ // it shouldn't be needed to filter the labels since they are based on the values which where already filtered.`
`231`	`231`	`propertyMap[label] = labels;`
`232`	`232`	`}`
`233`	`233`	`}`