Skip to content

expose AxisManager in pl init#223

Open
vbrennsteiner wants to merge 1 commit into
mainfrom
AxesManager_to_pl_init
Open

expose AxisManager in pl init#223
vbrennsteiner wants to merge 1 commit into
mainfrom
AxesManager_to_pl_init

Conversation

@vbrennsteiner
Copy link
Copy Markdown
Collaborator

makes it possible to use apt.pl.AxisManager in type hints

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the alphapepttools.pl package’s public API to re-export AxisManager, enabling apt.pl.AxisManager to be referenced directly in type hints and user code.

Changes:

  • Re-export AxisManager from alphapepttools.pl.figure at the package level (alphapepttools.pl).
  • Add AxisManager to alphapepttools.pl.__all__ so it is included in the intended public surface.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@lucas-diedrich lucas-diedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really get the reasoning - this already works

from alphapepttools.pl.figure import AxisManager

def func(manager: AxisManager) -> None:
    ... 

Note the full path (including module)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants