Review TMT tutorial notebook#227
Open
vbrennsteiner wants to merge 21 commits into
Open
Conversation
Claude: Implement the group_column logic in @src/alphapepttools/pp/norm.py. The logic should follow the logic in the @src/alphapepttools/pp/impute.py module. ⎿ Read src/alphapepttools/pp/norm.py (223 lines) ⎿ Read src/alphapepttools/pp/impute.py (572 lines)
Remove plot index offset
vbrennsteiner
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: in order to run grouped normalization, PR #217 was merged into this branch. Consequently, 217 should be merged into main before tmt-data.
NOTE: The change of bar/box/violin plot axis indices to 0-indexing was already merged to main and this PR, hence the diff in plots.py
NOTE: Ye olde Pandas warning for groupby without explicit observed=False appeared for CV calculation and grouped CVs, fixed it in the respective metrics by adding observed=False
Purpose of this PR
alphapepttoolsplots