Fix counting statistics with shorter trees#125
Merged
Conversation
ammarcsj
changed the title
mschwoer
approved these changes
Feb 13, 2026
File has no references anywhere in the codebase. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Not part of the public API; only called internally from _get_nodes_to_test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Scenario 1 was missing an inline comment explaining why mod_seq_charge is the test level when fragment data is present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Return the level value instead of setting the global inside the function; assign at the call site in _get_nodes_to_test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
In short trees (no fragment data), the leaves are the precursors themselves, making base-level testing the correct granularity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counting statistics module had an error on fragpipe data, because the tree format was not correctly recognized as reported here #105
Implemented a new function to determine the appropriate level for missing value statistical testing based on the tree structure, which is then used subsequently.