Skip to content

Commit f6e64b6

Browse files
mbucktonmbuckton
committed
chore(build): Update POMs for improved dependency management, SCM links, and Maven Central publishing configuration
- Use placeholders for dependency versions for consistency. - Update URLs for project documentation and SCM. - Add new dependencies (`canbus-events`, `snakeyaml`) and central repository configuration. - Refine plugin configurations for source, javadoc, and GPG signing. - Correct module descriptions for clarity in submodules.
1 parent f8460d3 commit f6e64b6

4 files changed

Lines changed: 56 additions & 25 deletions

File tree

‎canbus-J1939/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<packaging>jar</packaging>
3535

3636
<name>J1939 frame handler</name>
37-
<description>Parses J1939 frames from canbus packets</description>
37+
<description>Parses J1939 frames from CAN bus packets</description>
3838

3939
<dependencies>
4040
<dependency>

‎canbus-events/pom.xml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,14 @@
1616
<packaging>jar</packaging>
1717

1818
<name>Raw CanBus event handler</name>
19-
<description>Parses raw canbus using the supplied config file frames from canbus packets</description>
19+
<description>Parses raw CAN bus frames using the supplied configuration file</description>
2020

2121
<dependencies>
2222
<dependency>
2323
<groupId>org.yaml</groupId>
2424
<artifactId>snakeyaml</artifactId>
25-
<version>2.2</version>
2625
</dependency>
2726

28-
2927
<dependency>
3028
<groupId>com.google.code.gson</groupId>
3129
<artifactId>gson</artifactId>

‎canbus-nmea2000/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<packaging>jar</packaging>
3535

3636
<name>NMEA 2000 parser, message formatter and schema</name>
37-
<description>Loads NMEA2000 XML and provides NMEA2000 to/from JSON parsing</description>
37+
<description>Loads NMEA 2000 XML and provides NMEA 2000 to/from JSON parsing</description>
3838

3939
<dependencies>
4040
<dependency>

‎pom.xml‎

Lines changed: 53 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
<name>CanBus</name>
3232
<description>CAN bus protocol stack and device interfaces</description>
33-
<url>http://www.mapsmessaging.io</url>
33+
<url>https://www.mapsmessaging.io</url>
3434

3535
<modules>
3636
<module>canbus-core</module>
@@ -70,9 +70,9 @@
7070
</licenses>
7171

7272
<scm>
73-
<url>https://github.com/Maps-Messaging/canbus-interface</url>
73+
<url>https://github.com/Maps-Messaging/canbus_interface</url>
7474
<connection>scm:git:https://github.com/Maps-Messaging/canbus_interface.git</connection>
75-
<developerConnection>scm:git:git@github.com:Maps-Messaging/canbus-interface</developerConnection>
75+
<developerConnection>scm:git:git@github.com:Maps-Messaging/canbus_interface.git</developerConnection>
7676
<tag>HEAD</tag>
7777
</scm>
7878

@@ -98,6 +98,7 @@
9898
<version.junit>6.0.1</version.junit>
9999
<version.mockito>5.21.0</version.mockito>
100100
<version.jsonSchemaValidator>1.5.1</version.jsonSchemaValidator>
101+
<version.snakeyaml>2.2</version.snakeyaml>
101102

102103
<version.mavenCompilerPlugin>3.14.1</version.mavenCompilerPlugin>
103104
<version.mavenSurefirePlugin>3.5.4</version.mavenSurefirePlugin>
@@ -113,6 +114,12 @@
113114
</properties>
114115

115116
<distributionManagement>
117+
<repository>
118+
<id>central</id>
119+
<name>Sonatype Central</name>
120+
<url>https://central.sonatype.com/api/v1/publisher</url>
121+
</repository>
122+
116123
<snapshotRepository>
117124
<id>maps_snapshots</id>
118125
<name>maps_snapshot_repository</name>
@@ -130,6 +137,12 @@
130137
<version>${project.version}</version>
131138
</dependency>
132139

140+
<dependency>
141+
<groupId>io.mapsmessaging</groupId>
142+
<artifactId>canbus-events</artifactId>
143+
<version>${project.version}</version>
144+
</dependency>
145+
133146
<dependency>
134147
<groupId>io.mapsmessaging</groupId>
135148
<artifactId>canbus-J1939</artifactId>
@@ -142,47 +155,53 @@
142155
<version>${project.version}</version>
143156
</dependency>
144157

145-
<!-- External deps (optional but recommended if you want versions centralized) -->
158+
<!-- External dependencies -->
146159
<dependency>
147160
<groupId>com.google.code.gson</groupId>
148161
<artifactId>gson</artifactId>
149-
<version>2.13.2</version>
162+
<version>${version.gson}</version>
150163
</dependency>
151164

152165
<dependency>
153166
<groupId>net.java.dev.jna</groupId>
154167
<artifactId>jna</artifactId>
155-
<version>5.18.1</version>
168+
<version>${version.jna}</version>
156169
</dependency>
157170

158171
<dependency>
159172
<groupId>com.networknt</groupId>
160173
<artifactId>json-schema-validator</artifactId>
161-
<version>1.5.1</version>
174+
<version>${version.jsonSchemaValidator}</version>
162175
</dependency>
163176

164177
<dependency>
165178
<groupId>org.mockito</groupId>
166179
<artifactId>mockito-core</artifactId>
167-
<version>5.21.0</version>
180+
<version>${version.mockito}</version>
168181
</dependency>
169182

170183
<dependency>
171184
<groupId>org.junit.jupiter</groupId>
172185
<artifactId>junit-jupiter-api</artifactId>
173-
<version>6.0.1</version>
186+
<version>${version.junit}</version>
174187
</dependency>
175188

176189
<dependency>
177190
<groupId>org.junit.jupiter</groupId>
178191
<artifactId>junit-jupiter-engine</artifactId>
179-
<version>6.0.1</version>
192+
<version>${version.junit}</version>
180193
</dependency>
181194

182195
<dependency>
183196
<groupId>org.projectlombok</groupId>
184197
<artifactId>lombok</artifactId>
185-
<version>1.18.38</version>
198+
<version>${version.lombok}</version>
199+
</dependency>
200+
201+
<dependency>
202+
<groupId>org.yaml</groupId>
203+
<artifactId>snakeyaml</artifactId>
204+
<version>${version.snakeyaml}</version>
186205
</dependency>
187206

188207
</dependencies>
@@ -216,7 +235,7 @@
216235
<plugin>
217236
<groupId>org.apache.maven.plugins</groupId>
218237
<artifactId>maven-surefire-plugin</artifactId>
219-
<version>3.5.4</version>
238+
<version>${version.mavenSurefirePlugin}</version>
220239
</plugin>
221240

222241
<plugin>
@@ -253,6 +272,7 @@
253272
<executions>
254273
<execution>
255274
<id>attach-sources</id>
275+
<phase>verify</phase>
256276
<goals>
257277
<goal>jar-no-fork</goal>
258278
</goals>
@@ -268,26 +288,24 @@
268288
<charset>UTF-8</charset>
269289
<encoding>UTF-8</encoding>
270290
<javadocExecutable>${java.home}/bin/javadoc</javadocExecutable>
271-
<outputDirectory>${project.build.directory}/site/docs</outputDirectory>
272291
<show>public</show>
292+
<failOnError>false</failOnError>
273293
<sourceFileExcludes>
274294
<sourceFileExclude>**/*Test.java</sourceFileExclude>
275295
<sourceFileExclude>**/Test*.java</sourceFileExclude>
276296
<sourceFileExclude>**/*IT.java</sourceFileExclude>
277297
</sourceFileExcludes>
298+
<additionalJOptions>
299+
<additionalJOption>-Xdoclint:none</additionalJOption>
300+
</additionalJOptions>
278301
</configuration>
279302
<executions>
280303
<execution>
281304
<id>attach-javadocs</id>
305+
<phase>verify</phase>
282306
<goals>
283307
<goal>jar</goal>
284308
</goals>
285-
<configuration>
286-
<failOnError>false</failOnError>
287-
<additionalJOptions>
288-
<additionalJOption>-Xdoclint:none</additionalJOption>
289-
</additionalJOptions>
290-
</configuration>
291309
</execution>
292310
</executions>
293311
</plugin>
@@ -376,6 +394,21 @@
376394
</properties>
377395
<build>
378396
<plugins>
397+
<plugin>
398+
<groupId>org.apache.maven.plugins</groupId>
399+
<artifactId>maven-source-plugin</artifactId>
400+
</plugin>
401+
402+
<plugin>
403+
<groupId>org.apache.maven.plugins</groupId>
404+
<artifactId>maven-javadoc-plugin</artifactId>
405+
</plugin>
406+
407+
<plugin>
408+
<groupId>org.apache.maven.plugins</groupId>
409+
<artifactId>maven-gpg-plugin</artifactId>
410+
</plugin>
411+
379412
<plugin>
380413
<groupId>org.sonatype.central</groupId>
381414
<artifactId>central-publishing-maven-plugin</artifactId>
@@ -417,4 +450,4 @@
417450
</profile>
418451
</profiles>
419452

420-
</project>
453+
</project>

0 commit comments

Comments
 (0)